Re: [PATCH RFC] xfs: add FALLOC_FL_WRITE_ZEROES to XFS code base

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Oct 03, 2025 at 12:51:05AM -0700, Christoph Hellwig wrote:
> On Thu, Oct 02, 2025 at 02:28:24PM +0200, Lukas Herbolt wrote:
> >  int
> >  xfs_alloc_file_space(
> >  	struct xfs_inode	*ip,
> > +    uint32_t        flags,      /* XFS_BMAPI_... */
> 
> This seems to mix tabs and spaces.
> 
> >  static int
> >  xfs_falloc_zero_range(
> >  	struct file		*file,
> > -	int			mode,
> > +	int				mode,
> 
> More whitespace damage here.
> 
> >  	loff_t			offset,
> >  	loff_t			len,
> >  	struct xfs_zone_alloc_ctx *ac)
> > @@ -1277,7 +1277,16 @@ xfs_falloc_zero_range(
> >  
> >  	len = round_up(offset + len, blksize) - round_down(offset, blksize);
> >  	offset = round_down(offset, blksize);
> > -	error = xfs_alloc_file_space(XFS_I(inode), offset, len);
> > +	if (mode & FALLOC_FL_WRITE_ZEROES) {
> > +		if (!bdev_write_zeroes_unmap_sectors(inode->i_sb->s_bdev))

     		                         not correct ^^^^^^^^^^^^^^^^^^^

You need to find the block device associated with the file because XFS
is a multi-device filesystem.

--D

> > +	        return -EOPNOTSUPP;
> > +		error = xfs_alloc_file_space(XFS_I(inode), XFS_BMAPI_ZERO,
> > +				offset, len);
> > +	}
> > +	else
> 
> The closing brace goes onto the same line as the else, and we usually
> add the brace in all branches.
> 
> Otherwise this looks fine.
>