linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Herbolt <lukas@herbolt.com>
To: djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, Lukas Herbolt <lukas@herbolt.com>
Subject: [PATCH v2] mkfs.xfs fix sunit size on 512e and 4kN disks.
Date: Tue,  7 Oct 2025 09:13:00 +0200	[thread overview]
Message-ID: <20251007071259.51015-2-lukas@herbolt.com> (raw)
In-Reply-To: <aN9_ZfFEdDCuSTJW@infradead.org>

>> and should be done in a prep patch
Not sure if I got it right, but sending v2

Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
---
v2: rework check lsu only if LSU comes from CLI

---
 mkfs/xfs_mkfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 8cd4ccd7..3aecacd3 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3644,7 +3644,7 @@ check_lsunit:
 	else if (cfg->lsectorsize > XLOG_HEADER_SIZE)
 		lsu = cfg->blocksize; /* lsunit matches filesystem block size */
 
-	if (lsu) {
+	if (cli->lsu) {
 		/* verify if lsu is a multiple block size */
 		if (lsu % cfg->blocksize != 0) {
 			fprintf(stderr,
-- 
2.51.0


  reply	other threads:[~2025-10-07  7:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 12:38 [PATCH] mkfs.xfs fix sunit size on 512e and 4kN disks Lukas Herbolt
2025-09-29  6:54 ` Christoph Hellwig
2025-09-29  8:59   ` lukas
2025-10-03  7:46     ` Christoph Hellwig
2025-10-07  7:13       ` Lukas Herbolt [this message]
2025-10-08  6:06         ` [PATCH v2] " Christoph Hellwig
2025-10-15  6:52 ` [PATCH] " Donald Douwsma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251007071259.51015-2-lukas@herbolt.com \
    --to=lukas@herbolt.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).