* [PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry
@ 2025-10-11 18:34 Darrick J. Wong
2025-10-13 3:19 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2025-10-11 18:34 UTC (permalink / raw)
To: Andrey Albershteyn; +Cc: xfs
From: Darrick J. Wong <djwong@kernel.org>
Fix this copy-paste error -- we should calculate the rt volume
concurrency either if the user gave us an explicit option, or if they
didn't but the rt volume is an SSD.
Cc: <linux-xfs@vger.kernel.org> # v6.13.0
Fixes: 34738ff0ee80de ("mkfs: allow sizing realtime allocation groups for concurrency")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
mkfs/xfs_mkfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 0511f1745c47c1..bc6a28b63c24b2 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -4506,7 +4506,7 @@ _("rgsize (%s) not a multiple of fs blk size (%d)\n"),
cfg->rgsize = cfg->rtblocks;
cfg->rgcount = 0;
} else if (cli->rtvol_concurrency > 0 ||
- (cli->data_concurrency == -1 && rtdev_is_solidstate(xi))) {
+ (cli->rtvol_concurrency == -1 && rtdev_is_solidstate(xi))) {
calc_concurrency_rtgroup_geometry(cfg, cli, xi);
} else if (is_power_of_2(cfg->rtextblocks)) {
cfg->rgsize = calc_rgsize_extsize_power(cfg);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry
2025-10-11 18:34 [PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry Darrick J. Wong
@ 2025-10-13 3:19 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2025-10-13 3:19 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Andrey Albershteyn, xfs
On Sat, Oct 11, 2025 at 11:34:04AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Fix this copy-paste error -- we should calculate the rt volume
> concurrency either if the user gave us an explicit option, or if they
> didn't but the rt volume is an SSD.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-13 3:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-11 18:34 [PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry Darrick J. Wong
2025-10-13 3:19 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).