[PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry

[PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

Fix this copy-paste error -- we should calculate the rt volume
concurrency either if the user gave us an explicit option, or if they
didn't but the rt volume is an SSD.

Cc: <linux-xfs@vger.kernel.org> # v6.13.0
Fixes: 34738ff0ee80de ("mkfs: allow sizing realtime allocation groups for concurrency")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 mkfs/xfs_mkfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 0511f1745c47c1..bc6a28b63c24b2 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -4506,7 +4506,7 @@ _("rgsize (%s) not a multiple of fs blk size (%d)\n"),
 		cfg->rgsize = cfg->rtblocks;
 		cfg->rgcount = 0;
 	} else if (cli->rtvol_concurrency > 0 ||
-		   (cli->data_concurrency == -1 && rtdev_is_solidstate(xi))) {
+		   (cli->rtvol_concurrency == -1 && rtdev_is_solidstate(xi))) {
 		calc_concurrency_rtgroup_geometry(cfg, cli, xi);
 	} else if (is_power_of_2(cfg->rtextblocks)) {
 		cfg->rgsize = calc_rgsize_extsize_power(cfg);

Re: [PATCH] mkfs: fix copy-paste error in calculate_rtgroup_geometry

[Christoph Hellwig]

On Sat, Oct 11, 2025 at 11:34:04AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix this copy-paste error -- we should calculate the rt volume
> concurrency either if the user gave us an explicit option, or if they
> didn't but the rt volume is an SSD.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>