From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Hans Holmberg <hans.holmberg@wdc.com>
Subject: Re: [PATCH v3] xfs: do not tightly pack-write large files
Date: Tue, 14 Oct 2025 06:17:00 +0200 [thread overview]
Message-ID: <20251014041700.GA30243@lst.de> (raw)
In-Reply-To: <20251014040729.759700-1-dlemoal@kernel.org>
On Tue, Oct 14, 2025 at 01:07:29PM +0900, Damien Le Moal wrote:
> + /*
> + * Do not pack write files that are already using a full group (zone)
> + * to avoid fragmentation.
> + */
Same nitpick as first time, please either say realtime group / RTG or
zone, but this doubling up just adds confusion.
Given that the rest of this file talks about zones, zone might be the
best choice, but I don't have a strict preference.
prev parent reply other threads:[~2025-10-14 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 4:07 [PATCH v3] xfs: do not tightly pack-write large files Damien Le Moal
2025-10-14 4:17 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014041700.GA30243@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).