Re: [PATCH 15/17] xfs: move q_qlock acquisition into xqcheck_commit_dquot

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Oct 13, 2025 at 11:48:16AM +0900, Christoph Hellwig wrote:
> This removes a pointless roundtrip because xqcheck_commit_dquot has to
> drop the lock for allocating a transaction right now.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Ohhhh this looks so much better!
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/scrub/quotacheck_repair.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/xfs/scrub/quotacheck_repair.c b/fs/xfs/scrub/quotacheck_repair.c
> index de1521739ec9..942df94e1215 100644
> --- a/fs/xfs/scrub/quotacheck_repair.c
> +++ b/fs/xfs/scrub/quotacheck_repair.c
> @@ -52,13 +52,11 @@ xqcheck_commit_dquot(
>  	bool			dirty = false;
>  	int			error = 0;
>  
> -	/* Unlock the dquot just long enough to allocate a transaction. */
> -	mutex_unlock(&dq->q_qlock);
>  	error = xchk_trans_alloc(xqc->sc, 0);
> -	mutex_lock(&dq->q_qlock);
>  	if (error)
>  		return error;
>  
> +	mutex_lock(&dq->q_qlock);
>  	xfs_trans_dqjoin(xqc->sc->tp, dq);
>  
>  	if (xchk_iscan_aborted(&xqc->iscan)) {
> @@ -150,7 +148,6 @@ xqcheck_commit_dqtype(
>  	 */
>  	xchk_dqiter_init(&cursor, sc, dqtype);
>  	while ((error = xchk_dquot_iter(&cursor, &dq)) == 1) {
> -		mutex_lock(&dq->q_qlock);
>  		error = xqcheck_commit_dquot(xqc, dqtype, dq);
>  		xfs_qm_dqrele(dq);
>  		if (error)
> @@ -182,7 +179,6 @@ xqcheck_commit_dqtype(
>  		if (error)
>  			return error;
>  
> -		mutex_lock(&dq->q_qlock);
>  		error = xqcheck_commit_dquot(xqc, dqtype, dq);
>  		xfs_qm_dqrele(dq);
>  		if (error)
> -- 
> 2.47.3
> 
>