From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: zlang@redhat.com, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/8] generic/427: try to ensure there's some free space before we do the aio test
Date: Mon, 20 Oct 2025 11:35:34 -0700 [thread overview]
Message-ID: <20251020183534.GF3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <20251020141639.ekbpgtfjdyybd3wz@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Mon, Oct 20, 2025 at 10:16:39PM +0800, Zorro Lang wrote:
> On Wed, Oct 15, 2025 at 09:36:58AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > On a filesystem configured like this:
> > MKFS_OPTIONS="-m metadir=1,autofsck=1,uquota,gquota,pquota -d rtinherit=1 -r zoned=1"
> >
> > This test fails like this:
> >
> > --- a/tests/generic/427.out 2025-04-30 16:20:44.584246582 -0700
> > +++ b/tests/generic/427.out.bad 2025-07-14 10:47:07.605377287 -0700
> > @@ -1,2 +1,2 @@
> > QA output created by 427
> > -Success, all done.
> > +pwrite: No space left on device
>
> Hahah, I just felt weird, why g/427 failed as:
>
> QA output created by 427
> -pwrite: No space left on device
> +Success, all done.
>
> then I found `git am` treats above commit log as part of the patch :-D Please add
> some blanks to above fail messages.
>
> BTW, I decided not to merge this patchset in today's release, due to I haven't gotten
> time to give it enough test. I'll try to merge it (or part of it) in next release .
> Sorry for the late.
Will clean up and push out. Though now that there's an xfsprogs 6.17
release I guess I'll rerun everything with that and push out the
bugfixes tomorrow instead of today.
--D
> Thanks,
> Zorro
>
> >
> > The pwrite failure comes from the aio-dio-eof-race.c program because the
> > filesystem ran out of space. There are no speculative posteof
> > preallocations on a zoned filesystem, so let's skip this test on those
> > setups.
> >
> > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> > ---
> > tests/generic/427 | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> >
> > diff --git a/tests/generic/427 b/tests/generic/427
> > index bddfdb8714e9a7..bb20d9f44a2b5a 100755
> > --- a/tests/generic/427
> > +++ b/tests/generic/427
> > @@ -28,6 +28,9 @@ _require_no_compress
> > _scratch_mkfs_sized $((256 * 1024 * 1024)) >>$seqres.full 2>&1
> > _scratch_mount
> >
> > +# Zoned filesystems don't support speculative preallocations
> > +_require_inplace_writes $SCRATCH_MNT
> > +
> > # try to write more bytes than filesystem size to fill the filesystem,
> > # then remove all these data. If we still can find these stale data in
> > # a file' eofblock, then it's a bug
> >
>
next prev parent reply other threads:[~2025-10-20 18:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 16:36 [PATCHSET] fstests: more random fixes for v2025.10.05 Darrick J. Wong
2025-10-15 16:36 ` [PATCH 1/8] generic/427: try to ensure there's some free space before we do the aio test Darrick J. Wong
2025-10-17 4:18 ` Christoph Hellwig
2025-10-20 14:16 ` Zorro Lang
2025-10-20 18:35 ` Darrick J. Wong [this message]
2025-10-15 16:37 ` [PATCH 2/8] common/rc: fix _require_xfs_io_shutdown Darrick J. Wong
2025-10-17 4:18 ` Christoph Hellwig
2025-10-24 7:31 ` Nirjhar Roy (IBM)
2025-10-24 22:08 ` Darrick J. Wong
2025-10-30 6:31 ` Nirjhar Roy (IBM)
2025-10-15 16:37 ` [PATCH 3/8] generic/742: avoid infinite loop if no fiemap results Darrick J. Wong
2025-10-17 4:19 ` Christoph Hellwig
2025-10-15 16:37 ` [PATCH 4/8] generic/{482,757}: skip test if there are no FUA writes Darrick J. Wong
2025-10-17 4:22 ` Christoph Hellwig
2025-10-17 16:24 ` Darrick J. Wong
2025-10-20 6:59 ` Christoph Hellwig
2025-10-15 16:38 ` [PATCH 5/8] generic/772: actually check for file_getattr special file support Darrick J. Wong
2025-10-17 4:23 ` Christoph Hellwig
2025-10-17 17:46 ` Zorro Lang
2025-10-17 22:54 ` Darrick J. Wong
2025-10-18 7:57 ` Zorro Lang
2025-10-20 16:26 ` Darrick J. Wong
2025-10-24 7:44 ` Nirjhar Roy (IBM)
2025-10-24 22:10 ` Darrick J. Wong
2025-10-30 6:05 ` Nirjhar Roy (IBM)
2025-10-30 16:33 ` Darrick J. Wong
2025-10-15 16:38 ` [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags Darrick J. Wong
2025-10-17 4:23 ` Christoph Hellwig
2025-10-17 16:22 ` Darrick J. Wong
2025-10-20 7:01 ` Christoph Hellwig
2025-10-20 16:37 ` Darrick J. Wong
2025-10-21 5:30 ` Christoph Hellwig
2025-10-21 14:47 ` Darrick J. Wong
2025-10-15 16:38 ` [PATCH 7/8] common/attr: fix _require_noattr2 Darrick J. Wong
2025-10-17 4:24 ` Christoph Hellwig
2025-10-17 17:13 ` Zorro Lang
2025-10-17 22:55 ` Darrick J. Wong
2025-10-18 14:43 ` Zorro Lang
2025-10-20 16:27 ` Darrick J. Wong
2025-10-24 9:01 ` Nirjhar Roy (IBM)
2025-10-24 22:15 ` Darrick J. Wong
2025-10-30 6:02 ` Nirjhar Roy (IBM)
2025-10-15 16:38 ` [PATCH 8/8] common: fix _require_xfs_io_command pwrite -A for various blocksizes Darrick J. Wong
2025-10-17 4:24 ` Christoph Hellwig
2025-10-24 9:18 ` Nirjhar Roy (IBM)
2025-10-24 22:16 ` Darrick J. Wong
2025-10-30 6:03 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020183534.GF3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).