From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Carlos Maiolino <cem@kernel.org>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
Oleksandr Natalenko <oleksandr@natalenko.name>,
Pavel Reichl <preichl@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: [PATCH 4/3] xfs: fix locking in xchk_nlinks_collect_dir
Date: Tue, 21 Oct 2025 10:57:11 -0700 [thread overview]
Message-ID: <20251021175711.GJ3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <aPHYl6uFyxQjhwP5@infradead.org>
On Thu, Oct 16, 2025 at 10:48:07PM -0700, Christoph Hellwig wrote:
> > +static uint
> > +xchk_nlinks_ilock_dir(
> > + struct xfs_inode *ip)
> > +{
> > + uint lock_mode = XFS_ILOCK_SHARED;
> > +
> > + if (xfs_need_iread_extents(&ip->i_df))
> > + lock_mode = XFS_ILOCK_EXCL;
> > +
> > + if (xfs_has_parent(ip->i_mount) && xfs_inode_has_attr_fork(ip) &&
> > + xfs_need_iread_extents(&ip->i_af))
> > + lock_mode = XFS_ILOCK_EXCL;
>
> Please add a comment explaining the need for the conditions, this is too
> much black magic otherwise.
Done.
--D
prev parent reply other threads:[~2025-10-21 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 5:01 [PATCH v2 1/3] xfs: don't set bt_nr_sectors to a negative number Darrick J. Wong
2025-10-15 5:03 ` [PATCH v2 2/3] xfs: always warn about deprecated mount options Darrick J. Wong
2025-10-15 5:04 ` [PATCH v2 3/3] xfs: quietly ignore " Darrick J. Wong
2025-10-15 8:07 ` Vlastimil Babka
2025-10-15 15:37 ` Darrick J. Wong
2025-10-17 5:45 ` Christoph Hellwig
2025-10-17 5:46 ` Christoph Hellwig
2025-10-16 16:25 ` [PATCH 4/3] xfs: fix locking in xchk_nlinks_collect_dir Darrick J. Wong
2025-10-17 5:48 ` Christoph Hellwig
2025-10-21 17:57 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021175711.GJ3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=oleksandr@natalenko.name \
--cc=preichl@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox