Re: [PATCHv4 5/8] iomap: simplify direct io validity check

Keith Busch
2025-11-03T18:26:13Z

On Mon, Nov 03, 2025 at 10:10:31AM -0800, Eric Biggers wrote:
> On Fri, Oct 31, 2025 at 10:18:20AM +0100, Christoph Hellwig wrote:
> >
> > xfstests just started exercising this and we're getting lots of interesting
> > reports (for the non-fscrypt case).
>
> Great to hear that it's starting to be tested. But it's concerning that
> it's just happening now, 3 years after the patches went in, and is also
> still finding lots of bugs. It's hard for me to understand how it was
> ready, or even useful, in the first place.

I've been using these memory alignment capabilities in production for
quite some time without issue on real hardware, and it's proven very
useful at reducing memory and cpu utilization because that's really how
the data alignment comes into the services responisble for running the
disk io, and the alignment is outside the service's control.

Christoph is testing different use cases with check summing and finding
much of the infrastructure wasn't ready to accept the more arbitrary
memory offsets and lengths.

Finding it now is more of an indication that those two use cases haven't
overlapped.