From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, hans.holmberg@wdc.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix overflows when converting from a count of groups to blocks
Date: Thu, 30 Oct 2025 09:32:44 -0700 [thread overview]
Message-ID: <20251030163244.GL3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <20251030065439.GA13617@lst.de>
On Thu, Oct 30, 2025 at 07:54:39AM +0100, Christoph Hellwig wrote:
> On Mon, Oct 27, 2025 at 09:07:26AM -0700, Darrick J. Wong wrote:
> > >
> > > +static inline xfs_rfsblock_t
> > > +xfs_rtgs_to_rtb(
> >
> > ...especially since we're really not returning an rtblock here.
>
> What would be a good name here?
>
> xfs_rtgs_to_rfsb() ?
xfs_rtgs_to_rfsbs?
(rtg[roups]s is plural, so rfsb[lock]s should be too)
[this is all bs, yuk yuk, I'll be at this club all week :P]
--D
prev parent reply other threads:[~2025-10-30 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 14:04 [PATCH] xfs: fix overflows when converting from a count of groups to blocks Christoph Hellwig
2025-10-27 16:07 ` Darrick J. Wong
2025-10-30 6:54 ` Christoph Hellwig
2025-10-30 16:32 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030163244.GL3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).