Re: [PATCH 03/13] block: handle zone management operations completions

Bart Van Assche
2025-10-31T18:01:39Z

On 10/30/25 11:12 PM, Damien Le Moal wrote:
> +void blk_zone_mgmt_bio_endio(struct bio *bio)
> +{
> + /* If the BIO failed, we have nothing to do. */
> + if (bio->bi_status != BLK_STS_OK)
> + return;
> +
> + switch (bio_op(bio)) {
> + case REQ_OP_ZONE_RESET:
> + blk_zone_reset_bio_endio(bio);
> + return;
> + case REQ_OP_ZONE_RESET_ALL:
> + blk_zone_reset_all_bio_endio(bio);
> + return;
> + case REQ_OP_ZONE_FINISH:
> + blk_zone_finish_bio_endio(bio);
> + return;
> + default:
> + return;
> + }
> }

"default: return;" is superfluous and can be left out.

> + /*
> + * Zone mamnagement BIOs may impact zone write plugs (e.g. a zone reset

mamnagement -> management

Otherwise this patch looks good to me.

Thanks,

Bart.