Re: [PATCH 07/13] block: track zone conditions

Christoph Hellwig
2025-10-31T08:51:44Z

On Fri, Oct 31, 2025 at 03:13:01PM +0900, Damien Le Moal wrote:
> The function blk_revalidate_zone_cond() already cache the condition of

s/cache/caches/ ?

> diff --git a/include/uapi/linux/blkzoned.h b/include/uapi/linux/blkzoned.h
> index f85743ef6e7d..dab5d9700898 100644
> --- a/include/uapi/linux/blkzoned.h
> +++ b/include/uapi/linux/blkzoned.h
> @@ -61,6 +61,10 @@ enum blk_zone_type {
> *
> * Conditions 0x5 to 0xC are reserved by the current ZBC/ZAC spec and should
> * be considered invalid.
> + *
> + * The condition BLK_ZONE_COND_ACTIVE is used to represent any of the
> + * BLK_ZONE_COND_IMP_OPEN, BLK_ZONE_COND_EXP_OPEN and BLK_ZONE_COND_CLOSED
> + * conditions.

Maybe explain a bit more that this is only seen for cached reports, and
in that case the two open states and closed won't ever be seen, i.e.
that they are mutually exclusive?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>