Re: [PATCH 09/10] xfs: improve the iclog space assert in xlog_write_iovec

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Oct 30, 2025 at 03:49:19PM +0100, Christoph Hellwig wrote:
> We need enough space for the length we copy into the iclog, not just
> some space, so tighten up the check a bit.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Makes sense to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 7c751665bc44..8b8fdef6414d 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1889,7 +1889,7 @@ xlog_write_iovec(
>  	void			*buf,
>  	uint32_t		buf_len)
>  {
> -	ASSERT(xlog_write_space_left(data) > 0);
> +	ASSERT(xlog_write_space_left(data) >= buf_len);
>  	ASSERT(data->log_offset % sizeof(int32_t) == 0);
>  	ASSERT(buf_len % sizeof(int32_t) == 0);
>  
> -- 
> 2.47.3
> 
>