From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: free xfs_busy_extents structure when no RT extents are queued
Date: Wed, 5 Nov 2025 20:45:39 +0100 [thread overview]
Message-ID: <20251105194539.GA5780@lst.de> (raw)
In-Reply-To: <20251104165919.GJ196370@frogsfrogsfrogs>
On Tue, Nov 04, 2025 at 08:59:19AM -0800, Darrick J. Wong wrote:
> Yep, this fixes a memory leak. I wonder if you could combine the two
> into:
>
> if (error || !tr.queued) {
> kfree(tr.extents);
> break;
> }
>
> But I don't care passionately either way.
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
I'd rather keep the fix minimal for now, but yes, otherwise that would
work as well.
next prev parent reply other threads:[~2025-11-05 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 10:43 [PATCH] xfs: free xfs_busy_extents structure when no RT extents are queued Christoph Hellwig
2025-11-04 16:59 ` Darrick J. Wong
2025-11-05 19:45 ` Christoph Hellwig [this message]
2025-11-06 13:27 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105194539.GA5780@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).