From: Christoph Hellwig <hch@lst.de>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: Christoph Hellwig <hch@lst.de>,
Florian Weimer <fweimer@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, libc-alpha@sourceware.org
Subject: truncatat? was, Re: [RFC] xfs: fake fallocate success for always CoW inodes
Date: Mon, 10 Nov 2025 10:48:29 +0100 [thread overview]
Message-ID: <20251110094829.GA24081@lst.de> (raw)
In-Reply-To: <20251110093140.GA22674@lst.de>
On Mon, Nov 10, 2025 at 10:31:40AM +0100, Christoph Hellwig wrote:
> fallocate seems like an odd interface choice for that, but given that
> (f)truncate doesn't have a flags argument that might still be the
> least unexpected version.
>
> > Maybe add two flags, one for the ftruncate replacement, and one that
> > instructs the file system that the range will be used with mmap soon?
> > I expect this could be useful information to the file system. We
> > wouldn't use it in posix_fallocate, but applications calling fallocate
> > directly might.
>
> What do you think "to be used with mmap" flag could be useful for
> in the file system? For file systems mmap I/O isn't very different
> from other use cases.
The usual way to pass extra flags was the flats at for the *at syscalls.
truncate doesn't have that, and I wonder if there would be uses for
that? Because if so that feels like the right way to add that feature.
OTOH a quick internet search only pointed to a single question about it,
which was related to other confusion in the use of (f)truncate.
While adding a new system call can be rather cumbersome, the advantage
would be that we could implement the "only increase file size" flag
in common code and it would work on all file systems for kernels that
support the system call.
next prev parent reply other threads:[~2025-11-10 9:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 13:35 [RFC] xfs: fake fallocate success for always CoW inodes Hans Holmberg
2025-11-06 13:48 ` Florian Weimer
2025-11-06 13:52 ` Christoph Hellwig
2025-11-06 14:42 ` Matthew Wilcox
2025-11-06 14:46 ` Christoph Hellwig
2025-11-11 8:31 ` Hans Holmberg
2025-11-11 9:05 ` hch
2025-11-11 9:50 ` Florian Weimer
2025-11-11 13:40 ` hch
2025-11-06 16:31 ` Florian Weimer
2025-11-06 17:05 ` Christoph Hellwig
2025-11-08 12:30 ` Florian Weimer
2025-11-09 22:15 ` Dave Chinner
2025-11-10 5:27 ` Florian Weimer
2025-11-10 9:38 ` Christoph Hellwig
2025-11-10 10:03 ` Florian Weimer
2025-11-10 20:28 ` Dave Chinner
2025-11-11 8:56 ` Christoph Hellwig
2025-11-10 9:37 ` Christoph Hellwig
2025-11-10 9:44 ` Florian Weimer
2025-11-10 21:33 ` Dave Chinner
2025-11-11 9:04 ` Christoph Hellwig
2025-11-11 9:30 ` Florian Weimer
2025-11-10 9:31 ` Christoph Hellwig
2025-11-10 9:48 ` Christoph Hellwig [this message]
2025-11-10 10:00 ` truncatat? was, " Florian Weimer
2025-11-10 9:49 ` Florian Weimer
2025-11-10 9:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110094829.GA24081@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=hans.holmberg@wdc.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).