Re: [PATCH 01/18] xfs: don't leak a locked dquot when xfs_dquot_attach_buf fails

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Nov 10, 2025 at 02:22:53PM +0100, Christoph Hellwig wrote:
> xfs_qm_quotacheck_dqadjust acquired the dquot through xfs_qm_dqget,
> which means it owns a reference and holds q_qlock.  Both need to
> be dropped on an error exit.
> 
> Fixes: ca378189fdfa ("xfs: convert quotacheck to attach dquot buffers")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Yep, that was a bug, thanks for fixing that.

Cc: <stable@vger.kernel.org> # v6.13
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_qm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 23ba84ec919a..18a19947bbdb 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -1318,7 +1318,7 @@ xfs_qm_quotacheck_dqadjust(
>  
>  	error = xfs_dquot_attach_buf(NULL, dqp);
>  	if (error)
> -		return error;
> +		goto out_unlock;
>  
>  	trace_xfs_dqadjust(dqp);
>  
> @@ -1348,8 +1348,9 @@ xfs_qm_quotacheck_dqadjust(
>  	}
>  
>  	dqp->q_flags |= XFS_DQFLAG_DIRTY;
> +out_unlock:
>  	xfs_qm_dqput(dqp);
> -	return 0;
> +	return error;
>  }
>  
>  /*
> -- 
> 2.47.3
> 
>