Re: [PATCH] mkfs: fix zone capacity check for sequential zones

[Christoph Hellwig <hch@lst.de>]

On Wed, Nov 12, 2025 at 01:33:16PM +0100, cem@kernel.org wrote:
> FWIS, writing the patch description I'm assuming that the conventional zones
> always come first and we can't have a zoned device starting with
> sequential zones followed by conventional zones.

XFS kinda assumes this by not counting counting conventional zones found
after sequential zones, so we'll error out due to the lack of conventional
space later unless a separate device is used.

> +static void
> +zone_validate_capacity(
> +	struct zone_info	*zi,
> +	__u64			capacity,
> +	bool			conventional)
> +{
> +	if (conventional && (zi->zone_capacity != zi->zone_size)) {

No need for the inner braces.

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Note that we should also verify that if a device is used purely as
RT device (aka no internal RT device), that there are either no
conventional zones, or zone capacity == zone_size.  I can look into
that as an incremental patch.