Re: [PATCH 2/2] xfs_db: use push_cur_and_set_type more

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Nov 12, 2025 at 06:19:32PM +0300, Alexander Monakov wrote:
> Since push_cur unsets cur_typ, 'ls' and 'rdump' with paths relative to
> current address do not work with a mysterious diagnostic (claiming that
> the supplied name is not a directory). Use push_cur_and_set_type
> instead.

IOWs, you're trying to fix this, correct?

# xfs_db /dev/sdf
xfs_db> ls /
/:
8          128                directory      0x0000002e   1 . (good)
10         128                directory      0x0000172e   2 .. (good)
314        50337826           directory      0x0a152956   5 PPTRS (good)
xfs_db> ls ./PPTRS
./PPTRS: Not a directory

If so, then
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D


> Signed-off-by: Alexander Monakov <amonakov@ispras.ru>
> ---
>  db/namei.c | 2 +-
>  db/rdump.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/db/namei.c b/db/namei.c
> index 1d9581c3..4149503c 100644
> --- a/db/namei.c
> +++ b/db/namei.c
> @@ -629,7 +629,7 @@ ls_f(
>  	}
>  
>  	for (c = optind; c < argc; c++) {
> -		push_cur();
> +		push_cur_and_set_type();
>  
>  		error = path_walk(rootino, argv[c]);
>  		if (error)
> diff --git a/db/rdump.c b/db/rdump.c
> index 73295dbe..146f829b 100644
> --- a/db/rdump.c
> +++ b/db/rdump.c
> @@ -980,7 +980,7 @@ rdump_f(
>  			len--;
>  		argv[i][len] = 0;
>  
> -		push_cur();
> +		push_cur_and_set_type();
>  		ret = rdump_path(mp, argv[i], &destdir);
>  		pop_cur();
>  
> -- 
> 2.51.0
> 
>