From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 1/3] generic/484: force I/O to the data device for XFS
Date: Fri, 21 Nov 2025 08:10:05 +0100 [thread overview]
Message-ID: <20251121071013.93927-2-hch@lst.de> (raw)
In-Reply-To: <20251121071013.93927-1-hch@lst.de>
Otherwise the error injection to the data device might not work as
expected. For example in some zoned setups I see the failures in
a slightly different spot than expected without this.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/generic/484 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/generic/484 b/tests/generic/484
index ec50735a5b58..0455efcb6000 100755
--- a/tests/generic/484
+++ b/tests/generic/484
@@ -42,6 +42,9 @@ _scratch_mkfs > $seqres.full 2>&1
_dmerror_init
_dmerror_mount
+# ensure we are on the data device, as dm error inject the error there
+[ "$FSTYP" == "xfs" ] && _xfs_force_bdev data $SCRATCH_MNT
+
# create file
testfile=$SCRATCH_MNT/syncfs-reports-errors
touch $testfile
--
2.47.3
next prev parent reply other threads:[~2025-11-21 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 7:10 misc xfstests fixes Christoph Hellwig
2025-11-21 7:10 ` Christoph Hellwig [this message]
2025-11-21 16:35 ` [PATCH 1/3] generic/484: force I/O to the data device for XFS Darrick J. Wong
2025-11-21 7:10 ` [PATCH 2/3] xfs/049: create the nested XFS file systems on the loop device Christoph Hellwig
2025-11-21 16:43 ` Darrick J. Wong
2025-11-21 7:10 ` [PATCH 3/3] xfs/158: _notrun when the file system can't be created Christoph Hellwig
2025-11-21 17:04 ` Darrick J. Wong
2025-12-02 4:49 ` Zorro Lang
2025-12-02 7:36 ` Christoph Hellwig
2025-12-02 8:40 ` Zorro Lang
2025-12-05 7:31 ` Zorro Lang
2025-12-05 8:08 ` Christoph Hellwig
2025-12-05 17:33 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121071013.93927-2-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox