From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 2/3] xfs/049: create the nested XFS file systems on the loop device
Date: Fri, 21 Nov 2025 08:10:06 +0100 [thread overview]
Message-ID: <20251121071013.93927-3-hch@lst.de> (raw)
In-Reply-To: <20251121071013.93927-1-hch@lst.de>
Without this I see failures on 4k sector size RT devices, as mkfs.xfs
can't pick up the logical block size on files. Note that the test
already does this for the nested ext2 image as well.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/xfs/049 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/xfs/049 b/tests/xfs/049
index 07feb58c9ad6..a3f478fa9351 100755
--- a/tests/xfs/049
+++ b/tests/xfs/049
@@ -58,7 +58,9 @@ mount -t ext2 $SCRATCH_DEV $SCRATCH_MNT >> $seqres.full 2>&1 \
|| _fail "!!! failed to mount"
_log "Create xfs fs in file on scratch"
-${MKFS_XFS_PROG} -f -dfile,name=$SCRATCH_MNT/test.xfs,size=40m \
+truncate -s 40m $SCRATCH_MNT/test.xfs
+loop_dev1=$(_create_loop_device $SCRATCH_MNT/test.xfs)
+${MKFS_XFS_PROG} -f $loop_dev1 \
>> $seqres.full 2>&1 \
|| _fail "!!! failed to mkfs xfs"
@@ -67,7 +69,6 @@ mkdir $SCRATCH_MNT/test $SCRATCH_MNT/test2 >> $seqres.full 2>&1 \
|| _fail "!!! failed to make mount points"
_log "Mount xfs via loop"
-loop_dev1=$(_create_loop_device $SCRATCH_MNT/test.xfs)
_mount $loop_dev1 $SCRATCH_MNT/test >> $seqres.full 2>&1 \
|| _fail "!!! failed to loop mount xfs"
--
2.47.3
next prev parent reply other threads:[~2025-11-21 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 7:10 misc xfstests fixes Christoph Hellwig
2025-11-21 7:10 ` [PATCH 1/3] generic/484: force I/O to the data device for XFS Christoph Hellwig
2025-11-21 16:35 ` Darrick J. Wong
2025-11-21 7:10 ` Christoph Hellwig [this message]
2025-11-21 16:43 ` [PATCH 2/3] xfs/049: create the nested XFS file systems on the loop device Darrick J. Wong
2025-11-21 7:10 ` [PATCH 3/3] xfs/158: _notrun when the file system can't be created Christoph Hellwig
2025-11-21 17:04 ` Darrick J. Wong
2025-12-02 4:49 ` Zorro Lang
2025-12-02 7:36 ` Christoph Hellwig
2025-12-02 8:40 ` Zorro Lang
2025-12-05 7:31 ` Zorro Lang
2025-12-05 8:08 ` Christoph Hellwig
2025-12-05 17:33 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121071013.93927-3-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox