public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 3/3] xfs/158: _notrun when the file system can't be created
Date: Fri, 21 Nov 2025 08:10:07 +0100	[thread overview]
Message-ID: <20251121071013.93927-4-hch@lst.de> (raw)
In-Reply-To: <20251121071013.93927-1-hch@lst.de>

I get an "inode btree counters not supported without finobt support"
with some zoned setups with the latests xfsprogs.  Just _notrun the
test if we can't create the original file system feature combination
that we're trying to upgrade from.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/158 | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/xfs/158 b/tests/xfs/158
index 89bf8c851659..02ab39ffda0b 100755
--- a/tests/xfs/158
+++ b/tests/xfs/158
@@ -22,12 +22,14 @@ _scratch_mkfs -m crc=1,inobtcount=1,finobt=0 &> $seqres.full && \
 	echo "Should not be able to format with inobtcount but not finobt."
 
 # Make sure we can't upgrade a filesystem to inobtcount without finobt.
-_scratch_mkfs -m crc=1,inobtcount=0,finobt=0 >> $seqres.full
+try_scratch_mkfs -m crc=1,inobtcount=0,finobt=0 || \
+	_notrun "invalid feature combination" >> $seqres.full
 _scratch_xfs_admin -O inobtcount=1 2>> $seqres.full
 _check_scratch_xfs_features INOBTCNT
 
 # Format V5 filesystem without inode btree counter support and populate it.
-_scratch_mkfs -m crc=1,inobtcount=0 >> $seqres.full
+_scratch_mkfs -m crc=1,inobtcount=0 || \
+	_notrun "invalid feature combination" >> $seqres.full
 _scratch_mount
 
 mkdir $SCRATCH_MNT/stress
-- 
2.47.3


  parent reply	other threads:[~2025-11-21  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  7:10 misc xfstests fixes Christoph Hellwig
2025-11-21  7:10 ` [PATCH 1/3] generic/484: force I/O to the data device for XFS Christoph Hellwig
2025-11-21 16:35   ` Darrick J. Wong
2025-11-21  7:10 ` [PATCH 2/3] xfs/049: create the nested XFS file systems on the loop device Christoph Hellwig
2025-11-21 16:43   ` Darrick J. Wong
2025-11-21  7:10 ` Christoph Hellwig [this message]
2025-11-21 17:04   ` [PATCH 3/3] xfs/158: _notrun when the file system can't be created Darrick J. Wong
2025-12-02  4:49   ` Zorro Lang
2025-12-02  7:36     ` Christoph Hellwig
2025-12-02  8:40       ` Zorro Lang
2025-12-05  7:31   ` Zorro Lang
2025-12-05  8:08     ` Christoph Hellwig
2025-12-05 17:33       ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251121071013.93927-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox