Re: [PATCH 1/3] generic/484: force I/O to the data device for XFS

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Nov 21, 2025 at 08:10:05AM +0100, Christoph Hellwig wrote:
> Otherwise the error injection to the data device might not work as
> expected.  For example in some zoned setups I see the failures in
> a slightly different spot than expected without this.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Wow, how did I miss this all these years?

Ohhh, because this is an internal-rtdev failure isn't it?

How about removing the "unset SCRATCH_RTDEV" a few lines up too?

With that,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/generic/484 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/generic/484 b/tests/generic/484
> index ec50735a5b58..0455efcb6000 100755
> --- a/tests/generic/484
> +++ b/tests/generic/484
> @@ -42,6 +42,9 @@ _scratch_mkfs > $seqres.full 2>&1
>  _dmerror_init
>  _dmerror_mount
>  
> +# ensure we are on the data device, as dm error inject the error there
> +[ "$FSTYP" == "xfs" ] && _xfs_force_bdev data $SCRATCH_MNT
> +
>  # create file
>  testfile=$SCRATCH_MNT/syncfs-reports-errors
>  touch $testfile
> -- 
> 2.47.3
> 
>