Re: [PATCH 2/3] xfs/049: create the nested XFS file systems on the loop device

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Nov 21, 2025 at 08:10:06AM +0100, Christoph Hellwig wrote:
> Without this I see failures on 4k sector size RT devices, as mkfs.xfs
> can't pick up the logical block size on files.  Note that the test
> already does this for the nested ext2 image as well.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

LGTM,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/xfs/049 | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/xfs/049 b/tests/xfs/049
> index 07feb58c9ad6..a3f478fa9351 100755
> --- a/tests/xfs/049
> +++ b/tests/xfs/049
> @@ -58,7 +58,9 @@ mount -t ext2 $SCRATCH_DEV $SCRATCH_MNT >> $seqres.full 2>&1 \
>      || _fail "!!! failed to mount"
>  
>  _log "Create xfs fs in file on scratch"
> -${MKFS_XFS_PROG} -f -dfile,name=$SCRATCH_MNT/test.xfs,size=40m \
> +truncate -s 40m $SCRATCH_MNT/test.xfs
> +loop_dev1=$(_create_loop_device $SCRATCH_MNT/test.xfs)
> +${MKFS_XFS_PROG} -f $loop_dev1 \
>      >> $seqres.full 2>&1 \
>      || _fail "!!! failed to mkfs xfs"
>  
> @@ -67,7 +69,6 @@ mkdir $SCRATCH_MNT/test $SCRATCH_MNT/test2 >> $seqres.full 2>&1 \
>      || _fail "!!! failed to make mount points"
>  
>  _log "Mount xfs via loop"
> -loop_dev1=$(_create_loop_device $SCRATCH_MNT/test.xfs)
>  _mount $loop_dev1 $SCRATCH_MNT/test >> $seqres.full 2>&1 \
>      || _fail "!!! failed to loop mount xfs"
>  
> -- 
> 2.47.3
> 
>