From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 10/25] logprint: cleanup xlog_print_trans_inode_core
Date: Fri, 28 Nov 2025 07:29:47 +0100 [thread overview]
Message-ID: <20251128063007.1495036-11-hch@lst.de> (raw)
In-Reply-To: <20251128063007.1495036-1-hch@lst.de>
Re-indent and drop typedefs.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
logprint/log_misc.c | 69 +++++++++++++++++++++++++++------------------
1 file changed, 41 insertions(+), 28 deletions(-)
diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 227a0c84644f..a3aa4a323193 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -531,39 +531,52 @@ static void
xlog_print_trans_inode_core(
struct xfs_log_dinode *ip)
{
- xfs_extnum_t nextents;
-
- printf(_("INODE CORE\n"));
- printf(_("magic 0x%hx mode 0%ho version %d format %d\n"),
- ip->di_magic, ip->di_mode, (int)ip->di_version,
- (int)ip->di_format);
- printf(_("nlink %" PRIu32 " uid %d gid %d\n"),
- ip->di_nlink, ip->di_uid, ip->di_gid);
- printf(_("atime 0x%llx mtime 0x%llx ctime 0x%llx\n"),
+ xfs_extnum_t nextents;
+
+ printf(_("INODE CORE\n"));
+ printf(_("magic 0x%hx mode 0%ho version %d format %d\n"),
+ ip->di_magic,
+ ip->di_mode,
+ (int)ip->di_version,
+ (int)ip->di_format);
+ printf(_("nlink %" PRIu32 " uid %d gid %d\n"),
+ ip->di_nlink,
+ ip->di_uid,
+ ip->di_gid);
+ printf(_("atime 0x%llx mtime 0x%llx ctime 0x%llx\n"),
xlog_extract_dinode_ts(ip->di_atime),
xlog_extract_dinode_ts(ip->di_mtime),
xlog_extract_dinode_ts(ip->di_ctime));
- if (ip->di_flags2 & XFS_DIFLAG2_NREXT64)
- nextents = ip->di_big_nextents;
- else
- nextents = ip->di_nextents;
- printf(_("size 0x%llx nblocks 0x%llx extsize 0x%x nextents 0x%llx\n"),
- (unsigned long long)ip->di_size, (unsigned long long)ip->di_nblocks,
- ip->di_extsize, (unsigned long long)nextents);
+ if (ip->di_flags2 & XFS_DIFLAG2_NREXT64)
+ nextents = ip->di_big_nextents;
+ else
+ nextents = ip->di_nextents;
+ printf(_("size 0x%llx nblocks 0x%llx extsize 0x%x nextents 0x%llx\n"),
+ (unsigned long long)ip->di_size,
+ (unsigned long long)ip->di_nblocks,
+ ip->di_extsize,
+ (unsigned long long)nextents);
+
+ if (ip->di_flags2 & XFS_DIFLAG2_NREXT64)
+ nextents = ip->di_big_anextents;
+ else
+ nextents = ip->di_anextents;
+ printf(_("naextents 0x%llx forkoff %d dmevmask 0x%x dmstate 0x%hx\n"),
+ (unsigned long long)nextents,
+ (int)ip->di_forkoff,
+ ip->di_dmevmask,
+ ip->di_dmstate);
+ printf(_("flags 0x%x gen 0x%x\n"),
+ ip->di_flags,
+ ip->di_gen);
+
+ if (ip->di_version < 3)
+ return;
- if (ip->di_flags2 & XFS_DIFLAG2_NREXT64)
- nextents = ip->di_big_anextents;
- else
- nextents = ip->di_anextents;
- printf(_("naextents 0x%llx forkoff %d dmevmask 0x%x dmstate 0x%hx\n"),
- (unsigned long long)nextents, (int)ip->di_forkoff, ip->di_dmevmask, ip->di_dmstate);
- printf(_("flags 0x%x gen 0x%x\n"),
- ip->di_flags, ip->di_gen);
- if (ip->di_version == 3) {
- printf(_("flags2 0x%llx cowextsize 0x%x\n"),
- (unsigned long long)ip->di_flags2, ip->di_cowextsize);
- }
+ printf(_("flags2 0x%llx cowextsize 0x%x\n"),
+ (unsigned long long)ip->di_flags2,
+ ip->di_cowextsize);
}
static int
--
2.47.3
next prev parent reply other threads:[~2025-11-28 6:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 6:29 logprint cleanups, part1 Christoph Hellwig
2025-11-28 6:29 ` [PATCH 01/25] include: remove struct xfs_qoff_logitem Christoph Hellwig
2025-11-28 6:29 ` [PATCH 02/25] logprint: remove xlog_print_dir2_sf Christoph Hellwig
2025-11-28 6:29 ` [PATCH 03/25] logprint: re-indent printing helpers Christoph Hellwig
2025-11-28 6:29 ` [PATCH 04/25] logprint: cleanup xlog_print_op_header Christoph Hellwig
2025-11-28 6:29 ` [PATCH 05/25] logprint: cleanup struct xlog_split_item handling Christoph Hellwig
2025-11-28 6:29 ` [PATCH 06/25] logprint: cleanup xlog_print_trans_header Christoph Hellwig
2025-11-28 6:29 ` [PATCH 07/25] logprint: split per-type helpers out of xlog_print_trans_buffer Christoph Hellwig
2025-11-28 6:29 ` [PATCH 08/25] logprint: cleanup xlog_print_trans_buffer Christoph Hellwig
2025-11-28 6:29 ` [PATCH 09/25] logprint: cleanup xlog_print_trans_qoff Christoph Hellwig
2025-11-28 6:29 ` Christoph Hellwig [this message]
2025-12-01 18:23 ` [PATCH 10/25] logprint: cleanup xlog_print_trans_inode_core Andrey Albershteyn
2025-12-02 7:27 ` Christoph Hellwig
2025-11-28 6:29 ` [PATCH 11/25] logprint: move xfs_inode_item_format_convert up Christoph Hellwig
2025-12-01 18:32 ` Andrey Albershteyn
2025-12-02 7:28 ` Christoph Hellwig
2025-11-28 6:29 ` [PATCH 12/25] logprint: cleanup xlog_print_trans_inode Christoph Hellwig
2025-11-28 6:29 ` [PATCH 13/25] logprint: cleanup xlog_print_trans_dquot Christoph Hellwig
2025-11-28 6:29 ` [PATCH 14/25] logprint: re-indent print_lseek / print_lsn Christoph Hellwig
2025-11-28 6:29 ` [PATCH 15/25] logprint: factor out a xlog_print_process_region helper Christoph Hellwig
2025-11-28 6:29 ` [PATCH 16/25] logprint: factor out a xlog_print_op helper Christoph Hellwig
2025-12-01 18:44 ` Andrey Albershteyn
2025-12-02 7:29 ` Christoph Hellwig
2025-11-28 6:29 ` [PATCH 17/25] logprint: factor out a xlog_unpack_rec_header Christoph Hellwig
2025-11-28 6:29 ` [PATCH 18/25] logprint: cleanup xlog_print_record Christoph Hellwig
2025-11-28 6:29 ` [PATCH 19/25] logprint: cleanup xlog_print_rec_head Christoph Hellwig
2025-11-28 6:29 ` [PATCH 20/25] logprint: cleanup xlog_print_rec_xhead Christoph Hellwig
2025-11-28 6:29 ` [PATCH 21/25] logprint: re-indent print_xlog_bad_* Christoph Hellwig
2025-11-28 6:29 ` [PATCH 22/25] logprint: cleanup xlog_reallocate_xhdrs Christoph Hellwig
2025-11-28 6:30 ` [PATCH 23/25] logprint: factor out a xlog_print_ext_header helper Christoph Hellwig
2025-11-28 6:30 ` [PATCH 24/25] logprint: cleanup xlog_print_extended_headers Christoph Hellwig
2025-11-28 6:30 ` [PATCH 25/25] logprint: cleanup xfs_log_print Christoph Hellwig
2025-12-01 19:03 ` logprint cleanups, part1 Andrey Albershteyn
2025-12-02 7:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128063007.1495036-11-hch@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox