public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 19/25] logprint: cleanup xlog_print_rec_head
Date: Fri, 28 Nov 2025 07:29:56 +0100	[thread overview]
Message-ID: <20251128063007.1495036-20-hch@lst.de> (raw)
In-Reply-To: <20251128063007.1495036-1-hch@lst.de>

Re-indent and drop typedefs.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 logprint/log_misc.c | 119 +++++++++++++++++++++++---------------------
 1 file changed, 61 insertions(+), 58 deletions(-)

diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 3e67187d3fd4..1ac45a926c40 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -1171,78 +1171,81 @@ xlog_print_record(
 }
 
 static int
-xlog_print_rec_head(xlog_rec_header_t *head, int *len, int bad_hdr_warn)
+xlog_print_rec_head(
+	struct xlog_rec_header	*head,
+	int			*len,
+	int			bad_hdr_warn)
 {
-    int i;
-    char uub[64];
-    int datalen,bbs;
+	int			datalen, bbs;
+	char			uub[64];
+	int			i;
 
-    if (print_no_print)
-	    return be32_to_cpu(head->h_num_logops);
+	if (print_no_print)
+		return be32_to_cpu(head->h_num_logops);
 
-    if (!head->h_magicno)
-	return ZEROED_LOG;
+	if (!head->h_magicno)
+		return ZEROED_LOG;
 
-    if (be32_to_cpu(head->h_magicno) != XLOG_HEADER_MAGIC_NUM) {
-	if (bad_hdr_warn)
-		printf(_("Header 0x%x wanted 0x%x\n"),
-			be32_to_cpu(head->h_magicno),
-			XLOG_HEADER_MAGIC_NUM);
-	return BAD_HEADER;
-    }
+	if (be32_to_cpu(head->h_magicno) != XLOG_HEADER_MAGIC_NUM) {
+		if (bad_hdr_warn) {
+			printf(_("Header 0x%x wanted 0x%x\n"),
+				be32_to_cpu(head->h_magicno),
+				XLOG_HEADER_MAGIC_NUM);
+		}
+		return BAD_HEADER;
+	}
 
-    /* check for cleared blocks written by xlog_clear_stale_blocks() */
-    if (!head->h_len && !head->h_crc && !head->h_prev_block &&
-	!head->h_num_logops && !head->h_size)
-	return CLEARED_BLKS;
-
-    datalen=be32_to_cpu(head->h_len);
-    bbs=BTOBB(datalen);
-
-    printf(_("cycle: %d	version: %d	"),
-	    be32_to_cpu(head->h_cycle),
-	    be32_to_cpu(head->h_version));
-    print_lsn("	lsn", &head->h_lsn);
-    print_lsn("	tail_lsn", &head->h_tail_lsn);
-    printf("\n");
-    printf(_("length of Log Record: %d	prev offset: %d		num ops: %d\n"),
-	   datalen,
-	    be32_to_cpu(head->h_prev_block),
-	    be32_to_cpu(head->h_num_logops));
+	/* check for cleared blocks written by xlog_clear_stale_blocks() */
+	if (!head->h_len && !head->h_crc && !head->h_prev_block &&
+	    !head->h_num_logops && !head->h_size)
+		return CLEARED_BLKS;
 
-    if (print_overwrite) {
-	printf(_("cycle num overwrites: "));
-	for (i=0; i< min(bbs, XLOG_HEADER_CYCLE_SIZE / BBSIZE); i++)
-	    printf("%d - 0x%x  ",
-		    i,
-		    be32_to_cpu(head->h_cycle_data[i]));
+	datalen = be32_to_cpu(head->h_len);
+	bbs = BTOBB(datalen);
+
+	printf(_("cycle: %d	version: %d	"),
+		be32_to_cpu(head->h_cycle),
+		be32_to_cpu(head->h_version));
+	print_lsn("	lsn", &head->h_lsn);
+	print_lsn("	tail_lsn", &head->h_tail_lsn);
 	printf("\n");
-    }
+	printf(_("length of Log Record: %d	prev offset: %d		num ops: %d\n"),
+		datalen,
+		be32_to_cpu(head->h_prev_block),
+		be32_to_cpu(head->h_num_logops));
+
+	if (print_overwrite) {
+		printf(_("cycle num overwrites: "));
+		for (i = 0; i < min(bbs, XLOG_HEADER_CYCLE_SIZE / BBSIZE); i++)
+			printf("%d - 0x%x  ",
+				i, be32_to_cpu(head->h_cycle_data[i]));
+		printf("\n");
+	}
 
-    platform_uuid_unparse(&head->h_fs_uuid, uub);
-    printf(_("uuid: %s   format: "), uub);
-    switch (be32_to_cpu(head->h_fmt)) {
+	platform_uuid_unparse(&head->h_fs_uuid, uub);
+	printf(_("uuid: %s   format: "), uub);
+	switch (be32_to_cpu(head->h_fmt)) {
 	case XLOG_FMT_UNKNOWN:
-	    printf(_("unknown\n"));
-	    break;
+		printf(_("unknown\n"));
+		break;
 	case XLOG_FMT_LINUX_LE:
-	    printf(_("little endian linux\n"));
-	    break;
+		printf(_("little endian linux\n"));
+		break;
 	case XLOG_FMT_LINUX_BE:
-	    printf(_("big endian linux\n"));
-	    break;
+		printf(_("big endian linux\n"));
+		break;
 	case XLOG_FMT_IRIX_BE:
-	    printf(_("big endian irix\n"));
-	    break;
+		printf(_("big endian irix\n"));
+		break;
 	default:
-	    printf("? (%d)\n", be32_to_cpu(head->h_fmt));
-	    break;
-    }
-    printf(_("h_size: %d\n"), be32_to_cpu(head->h_size));
+		printf("? (%d)\n", be32_to_cpu(head->h_fmt));
+		break;
+	}
+	printf(_("h_size: %d\n"), be32_to_cpu(head->h_size));
 
-    *len = be32_to_cpu(head->h_len);
-    return(be32_to_cpu(head->h_num_logops));
-}	/* xlog_print_rec_head */
+	*len = be32_to_cpu(head->h_len);
+	return(be32_to_cpu(head->h_num_logops));
+}
 
 static void
 xlog_print_rec_xhead(xlog_rec_ext_header_t *head, int coverage)
-- 
2.47.3


  parent reply	other threads:[~2025-11-28  6:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28  6:29 logprint cleanups, part1 Christoph Hellwig
2025-11-28  6:29 ` [PATCH 01/25] include: remove struct xfs_qoff_logitem Christoph Hellwig
2025-11-28  6:29 ` [PATCH 02/25] logprint: remove xlog_print_dir2_sf Christoph Hellwig
2025-11-28  6:29 ` [PATCH 03/25] logprint: re-indent printing helpers Christoph Hellwig
2025-11-28  6:29 ` [PATCH 04/25] logprint: cleanup xlog_print_op_header Christoph Hellwig
2025-11-28  6:29 ` [PATCH 05/25] logprint: cleanup struct xlog_split_item handling Christoph Hellwig
2025-11-28  6:29 ` [PATCH 06/25] logprint: cleanup xlog_print_trans_header Christoph Hellwig
2025-11-28  6:29 ` [PATCH 07/25] logprint: split per-type helpers out of xlog_print_trans_buffer Christoph Hellwig
2025-11-28  6:29 ` [PATCH 08/25] logprint: cleanup xlog_print_trans_buffer Christoph Hellwig
2025-11-28  6:29 ` [PATCH 09/25] logprint: cleanup xlog_print_trans_qoff Christoph Hellwig
2025-11-28  6:29 ` [PATCH 10/25] logprint: cleanup xlog_print_trans_inode_core Christoph Hellwig
2025-12-01 18:23   ` Andrey Albershteyn
2025-12-02  7:27     ` Christoph Hellwig
2025-11-28  6:29 ` [PATCH 11/25] logprint: move xfs_inode_item_format_convert up Christoph Hellwig
2025-12-01 18:32   ` Andrey Albershteyn
2025-12-02  7:28     ` Christoph Hellwig
2025-11-28  6:29 ` [PATCH 12/25] logprint: cleanup xlog_print_trans_inode Christoph Hellwig
2025-11-28  6:29 ` [PATCH 13/25] logprint: cleanup xlog_print_trans_dquot Christoph Hellwig
2025-11-28  6:29 ` [PATCH 14/25] logprint: re-indent print_lseek / print_lsn Christoph Hellwig
2025-11-28  6:29 ` [PATCH 15/25] logprint: factor out a xlog_print_process_region helper Christoph Hellwig
2025-11-28  6:29 ` [PATCH 16/25] logprint: factor out a xlog_print_op helper Christoph Hellwig
2025-12-01 18:44   ` Andrey Albershteyn
2025-12-02  7:29     ` Christoph Hellwig
2025-11-28  6:29 ` [PATCH 17/25] logprint: factor out a xlog_unpack_rec_header Christoph Hellwig
2025-11-28  6:29 ` [PATCH 18/25] logprint: cleanup xlog_print_record Christoph Hellwig
2025-11-28  6:29 ` Christoph Hellwig [this message]
2025-11-28  6:29 ` [PATCH 20/25] logprint: cleanup xlog_print_rec_xhead Christoph Hellwig
2025-11-28  6:29 ` [PATCH 21/25] logprint: re-indent print_xlog_bad_* Christoph Hellwig
2025-11-28  6:29 ` [PATCH 22/25] logprint: cleanup xlog_reallocate_xhdrs Christoph Hellwig
2025-11-28  6:30 ` [PATCH 23/25] logprint: factor out a xlog_print_ext_header helper Christoph Hellwig
2025-11-28  6:30 ` [PATCH 24/25] logprint: cleanup xlog_print_extended_headers Christoph Hellwig
2025-11-28  6:30 ` [PATCH 25/25] logprint: cleanup xfs_log_print Christoph Hellwig
2025-12-01 19:03 ` logprint cleanups, part1 Andrey Albershteyn
2025-12-02  7:29   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251128063007.1495036-20-hch@lst.de \
    --to=hch@lst.de \
    --cc=aalbersh@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox