From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 04/25] logprint: cleanup xlog_print_op_header
Date: Fri, 28 Nov 2025 07:29:41 +0100 [thread overview]
Message-ID: <20251128063007.1495036-5-hch@lst.de> (raw)
In-Reply-To: <20251128063007.1495036-1-hch@lst.de>
Re-indent and drop typedef use.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
logprint/log_misc.c | 75 +++++++++++++++++++++++----------------------
1 file changed, 38 insertions(+), 37 deletions(-)
diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 505b6f0fa150..5d44c2b1eb67 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -98,44 +98,45 @@ print_or_dump(char *ptr, int len)
* a log operation header.
*/
void
-xlog_print_op_header(xlog_op_header_t *op_head,
- int i,
- char **ptr)
+xlog_print_op_header(
+ struct xlog_op_header *ophdr,
+ int i,
+ char **ptr)
{
- xlog_op_header_t hbuf;
-
- /*
- * memmove because on 64/n32, partial reads can cause the op_head
- * pointer to come in pointing to an odd-numbered byte
- */
- memmove(&hbuf, op_head, sizeof(xlog_op_header_t));
- op_head = &hbuf;
- *ptr += sizeof(xlog_op_header_t);
- printf(_("Oper (%d): tid: %x len: %d clientid: %s "), i,
- be32_to_cpu(op_head->oh_tid),
- be32_to_cpu(op_head->oh_len),
- (op_head->oh_clientid == XFS_TRANSACTION ? "TRANS" :
- (op_head->oh_clientid == XFS_LOG ? "LOG" : "ERROR")));
- printf(_("flags: "));
- if (op_head->oh_flags) {
- if (op_head->oh_flags & XLOG_START_TRANS)
- printf("START ");
- if (op_head->oh_flags & XLOG_COMMIT_TRANS)
- printf("COMMIT ");
- if (op_head->oh_flags & XLOG_WAS_CONT_TRANS)
- printf("WAS_CONT ");
- if (op_head->oh_flags & XLOG_UNMOUNT_TRANS)
- printf("UNMOUNT ");
- if (op_head->oh_flags & XLOG_CONTINUE_TRANS)
- printf("CONTINUE ");
- if (op_head->oh_flags & XLOG_END_TRANS)
- printf("END ");
- } else {
- printf(_("none"));
- }
- printf("\n");
-} /* xlog_print_op_header */
-
+ struct xlog_op_header hbuf;
+
+ /*
+ * memmove because on 64/n32, partial reads can cause the op_head
+ * pointer to come in pointing to an odd-numbered byte
+ */
+ memmove(&hbuf, ophdr, sizeof(hbuf));
+ ophdr = &hbuf;
+ *ptr += sizeof(hbuf);
+
+ printf(_("Oper (%d): tid: %x len: %d clientid: %s "), i,
+ be32_to_cpu(ophdr->oh_tid),
+ be32_to_cpu(ophdr->oh_len),
+ (ophdr->oh_clientid == XFS_TRANSACTION ? "TRANS" :
+ (ophdr->oh_clientid == XFS_LOG ? "LOG" : "ERROR")));
+ printf(_("flags: "));
+ if (ophdr->oh_flags) {
+ if (ophdr->oh_flags & XLOG_START_TRANS)
+ printf("START ");
+ if (ophdr->oh_flags & XLOG_COMMIT_TRANS)
+ printf("COMMIT ");
+ if (ophdr->oh_flags & XLOG_WAS_CONT_TRANS)
+ printf("WAS_CONT ");
+ if (ophdr->oh_flags & XLOG_UNMOUNT_TRANS)
+ printf("UNMOUNT ");
+ if (ophdr->oh_flags & XLOG_CONTINUE_TRANS)
+ printf("CONTINUE ");
+ if (ophdr->oh_flags & XLOG_END_TRANS)
+ printf("END ");
+ } else {
+ printf(_("none"));
+ }
+ printf("\n");
+}
static void
xlog_print_add_to_trans(xlog_tid_t tid,
--
2.47.3
next prev parent reply other threads:[~2025-11-28 6:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 6:29 logprint cleanups, part1 Christoph Hellwig
2025-11-28 6:29 ` [PATCH 01/25] include: remove struct xfs_qoff_logitem Christoph Hellwig
2025-11-28 6:29 ` [PATCH 02/25] logprint: remove xlog_print_dir2_sf Christoph Hellwig
2025-11-28 6:29 ` [PATCH 03/25] logprint: re-indent printing helpers Christoph Hellwig
2025-11-28 6:29 ` Christoph Hellwig [this message]
2025-11-28 6:29 ` [PATCH 05/25] logprint: cleanup struct xlog_split_item handling Christoph Hellwig
2025-11-28 6:29 ` [PATCH 06/25] logprint: cleanup xlog_print_trans_header Christoph Hellwig
2025-11-28 6:29 ` [PATCH 07/25] logprint: split per-type helpers out of xlog_print_trans_buffer Christoph Hellwig
2025-11-28 6:29 ` [PATCH 08/25] logprint: cleanup xlog_print_trans_buffer Christoph Hellwig
2025-11-28 6:29 ` [PATCH 09/25] logprint: cleanup xlog_print_trans_qoff Christoph Hellwig
2025-11-28 6:29 ` [PATCH 10/25] logprint: cleanup xlog_print_trans_inode_core Christoph Hellwig
2025-12-01 18:23 ` Andrey Albershteyn
2025-12-02 7:27 ` Christoph Hellwig
2025-11-28 6:29 ` [PATCH 11/25] logprint: move xfs_inode_item_format_convert up Christoph Hellwig
2025-12-01 18:32 ` Andrey Albershteyn
2025-12-02 7:28 ` Christoph Hellwig
2025-11-28 6:29 ` [PATCH 12/25] logprint: cleanup xlog_print_trans_inode Christoph Hellwig
2025-11-28 6:29 ` [PATCH 13/25] logprint: cleanup xlog_print_trans_dquot Christoph Hellwig
2025-11-28 6:29 ` [PATCH 14/25] logprint: re-indent print_lseek / print_lsn Christoph Hellwig
2025-11-28 6:29 ` [PATCH 15/25] logprint: factor out a xlog_print_process_region helper Christoph Hellwig
2025-11-28 6:29 ` [PATCH 16/25] logprint: factor out a xlog_print_op helper Christoph Hellwig
2025-12-01 18:44 ` Andrey Albershteyn
2025-12-02 7:29 ` Christoph Hellwig
2025-11-28 6:29 ` [PATCH 17/25] logprint: factor out a xlog_unpack_rec_header Christoph Hellwig
2025-11-28 6:29 ` [PATCH 18/25] logprint: cleanup xlog_print_record Christoph Hellwig
2025-11-28 6:29 ` [PATCH 19/25] logprint: cleanup xlog_print_rec_head Christoph Hellwig
2025-11-28 6:29 ` [PATCH 20/25] logprint: cleanup xlog_print_rec_xhead Christoph Hellwig
2025-11-28 6:29 ` [PATCH 21/25] logprint: re-indent print_xlog_bad_* Christoph Hellwig
2025-11-28 6:29 ` [PATCH 22/25] logprint: cleanup xlog_reallocate_xhdrs Christoph Hellwig
2025-11-28 6:30 ` [PATCH 23/25] logprint: factor out a xlog_print_ext_header helper Christoph Hellwig
2025-11-28 6:30 ` [PATCH 24/25] logprint: cleanup xlog_print_extended_headers Christoph Hellwig
2025-11-28 6:30 ` [PATCH 25/25] logprint: cleanup xfs_log_print Christoph Hellwig
2025-12-01 19:03 ` logprint cleanups, part1 Andrey Albershteyn
2025-12-02 7:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128063007.1495036-5-hch@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox