From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrey Albershteyn <aalbersh@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] repair: add a enum for the XR_INO_* values
Date: Mon, 1 Dec 2025 07:22:41 +0100 [thread overview]
Message-ID: <20251201062241.GA19310@lst.de> (raw)
In-Reply-To: <gsry5zrjmrda6m6yj7o2wifqgf5gg4hpbcaej7ehon3aqdbswt@lewg6qgjizhx>
On Fri, Nov 28, 2025 at 08:53:16AM +0100, Carlos Maiolino wrote:
> I think those comments are redundant as the enums are mostly
> self-descriptive, but independent of that the patch looks good.
Most seem on their own, but given that this is mixing file type, data vs
rt device, and magic metafiles into a single enum I think it's worth
keeping.
next prev parent reply other threads:[~2025-12-01 6:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 6:36 repair tidyups for metadir handling Christoph Hellwig
2025-11-28 6:36 ` [PATCH 1/4] repair: add a enum for the XR_INO_* values Christoph Hellwig
2025-11-28 7:53 ` Carlos Maiolino
2025-12-01 6:22 ` Christoph Hellwig [this message]
2025-12-01 9:00 ` Carlos Maiolino
2025-12-01 22:37 ` Darrick J. Wong
2025-11-28 6:37 ` [PATCH 2/4] repair: add canonical names for the XR_INO_ constants Christoph Hellwig
2025-11-28 8:00 ` Carlos Maiolino
2025-12-01 6:23 ` Christoph Hellwig
2025-12-01 22:47 ` Darrick J. Wong
2025-12-02 7:33 ` Christoph Hellwig
2025-12-02 17:59 ` Darrick J. Wong
2025-12-03 6:09 ` Christoph Hellwig
2025-12-04 17:18 ` Darrick J. Wong
2025-12-05 8:13 ` Christoph Hellwig
2025-12-05 16:29 ` Darrick J. Wong
2025-11-28 6:37 ` [PATCH 3/4] repair: factor out a process_dinode_metafile helper Christoph Hellwig
2025-11-28 8:05 ` Carlos Maiolino
2025-12-01 22:47 ` Darrick J. Wong
2025-11-28 6:37 ` [PATCH 4/4] repair: enhance process_dinode_metafile Christoph Hellwig
2025-11-28 8:15 ` Carlos Maiolino
2025-12-01 6:23 ` Christoph Hellwig
2025-12-01 9:01 ` Carlos Maiolino
2025-12-01 22:48 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2025-12-08 7:11 repair tidyups for metadir handling v2 Christoph Hellwig
2025-12-08 7:11 ` [PATCH 1/4] repair: add a enum for the XR_INO_* values Christoph Hellwig
2025-12-10 5:54 repair tidyups for metadir handling v3 Christoph Hellwig
2025-12-10 5:54 ` [PATCH 1/4] repair: add a enum for the XR_INO_* values Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201062241.GA19310@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox