public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Andrey Albershteyn <aalbersh@kernel.org>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/4] repair: add canonical names for the XR_INO_ constants
Date: Tue, 2 Dec 2025 08:33:07 +0100	[thread overview]
Message-ID: <20251202073307.GE18046@lst.de> (raw)
In-Reply-To: <20251201224716.GC89472@frogsfrogsfrogs>

On Mon, Dec 01, 2025 at 02:47:16PM -0800, Darrick J. Wong wrote:
> BUILD_BUG_ON(ARRAY_SIZED(xr_ino_type_name) != XR_INO_MAX);

Or static_assert for the standard userspace version?

> > +_("size of %s inode %" PRIu64 " != 0 (%" PRId64 " bytes)\n"),
> > +				xr_ino_type_name[type], lino,
> 
> i18n nit: In the old code, the inode description ("realtime bitmap")
> would be translated, now they aren't.  I don't know of a good way to
> maintain that though...
> 
> "el tamaño del realtime bitmap nodo 55 != 0"
> 
>                ^^^^^^^^^^^^^^^ whee, English in the middle of Spanish!
> 
> I guess you could write "_(xr_ino_type_name[type])" for that second
> argument.

Seems like the standard gettext thing to do is to mark the array
initializers as N_(), which we do in quite a few places.  Not sure
where the actual translation actually gets applied with that, though.


  reply	other threads:[~2025-12-02  7:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28  6:36 repair tidyups for metadir handling Christoph Hellwig
2025-11-28  6:36 ` [PATCH 1/4] repair: add a enum for the XR_INO_* values Christoph Hellwig
2025-11-28  7:53   ` Carlos Maiolino
2025-12-01  6:22     ` Christoph Hellwig
2025-12-01  9:00       ` Carlos Maiolino
2025-12-01 22:37         ` Darrick J. Wong
2025-11-28  6:37 ` [PATCH 2/4] repair: add canonical names for the XR_INO_ constants Christoph Hellwig
2025-11-28  8:00   ` Carlos Maiolino
2025-12-01  6:23     ` Christoph Hellwig
2025-12-01 22:47   ` Darrick J. Wong
2025-12-02  7:33     ` Christoph Hellwig [this message]
2025-12-02 17:59       ` Darrick J. Wong
2025-12-03  6:09         ` Christoph Hellwig
2025-12-04 17:18           ` Darrick J. Wong
2025-12-05  8:13             ` Christoph Hellwig
2025-12-05 16:29               ` Darrick J. Wong
2025-11-28  6:37 ` [PATCH 3/4] repair: factor out a process_dinode_metafile helper Christoph Hellwig
2025-11-28  8:05   ` Carlos Maiolino
2025-12-01 22:47   ` Darrick J. Wong
2025-11-28  6:37 ` [PATCH 4/4] repair: enhance process_dinode_metafile Christoph Hellwig
2025-11-28  8:15   ` Carlos Maiolino
2025-12-01  6:23     ` Christoph Hellwig
2025-12-01  9:01       ` Carlos Maiolino
2025-12-01 22:48   ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2025-12-08  7:11 repair tidyups for metadir handling v2 Christoph Hellwig
2025-12-08  7:11 ` [PATCH 2/4] repair: add canonical names for the XR_INO_ constants Christoph Hellwig
2025-12-08 17:36   ` Darrick J. Wong
2025-12-09  6:57     ` Christoph Hellwig
2025-12-09 15:59   ` Darrick J. Wong
2025-12-09 16:20     ` Christoph Hellwig
2025-12-09 16:26       ` Darrick J. Wong
2025-12-10  5:54 repair tidyups for metadir handling v3 Christoph Hellwig
2025-12-10  5:54 ` [PATCH 2/4] repair: add canonical names for the XR_INO_ constants Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251202073307.GE18046@lst.de \
    --to=hch@lst.de \
    --cc=aalbersh@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox