From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, aalbersh@kernel.org, cem@kernel.org,
cmaiolino@redhat.com, djwong@kernel.org, dlemoal@kernel.org,
hans.holmberg@wdc.com, preichl@redhat.com
Subject: Re: [PATCH 23/33] xfs: convert xfs_buf_log_format_t typedef to struct
Date: Thu, 4 Dec 2025 11:08:20 +0100 [thread overview]
Message-ID: <20251204100820.GA21013@lst.de> (raw)
In-Reply-To: <2vhe7x2wsydpko2n272dppoqk6kxe7ejkx2lwpmg6pa56mmnzf@f64b4gg4dpuv>
On Thu, Dec 04, 2025 at 11:00:51AM +0100, Andrey Albershteyn wrote:
> > > + xfs_log_item_t bli_item; /* common item structure */
> >
> > This should be struct xfs_log_item.
>
> hmm, I think this one (and xfs_buf_log_item_t) wasn't propagated to
> xfsprogs. I see your commit in kernel but that's from 2019.
Oops. I can take care of that, but for anything you touch anyway,
please avoid the typedef.
> > And this clashed with the series I had, which also splits things up.
> > But I guess we should just do the quick conversion given that you've
> > done all the work and I was too slow.
> >
>
> If you have more cleanups I can also include them, I want to prepare
> everything for soonish v6.18 release and include that fix for
> xfs_quota (which I will probably send today, not sure if reporter
> will send the fix).
I have a quite a bit of dusting off for logprint. But let's get a 6.18
release out first, I'll send them for 6.19. There's also a lot more
work for the iclog_incore2 removal, including really nice cleanups
enabled by that.
next prev parent reply other threads:[~2025-12-04 10:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 19:03 [PATCH 0/34] xfsprogs: libxfs sync v6.18 Andrey Albershteyn
2025-12-03 19:04 ` [PATCH 1/33] xfs: remove deprecated mount options Andrey Albershteyn
2025-12-03 19:04 ` [PATCH 2/33] xfs: remove deprecated sysctl knobs Andrey Albershteyn
2025-12-03 19:04 ` [PATCH 3/33] xfs: remove the xlog_op_header_t typedef Andrey Albershteyn
2025-12-04 9:29 ` Christoph Hellwig
2025-12-03 19:05 ` [PATCH 4/33] xfs: remove the xfs_trans_header_t typedef Andrey Albershteyn
2025-12-03 19:05 ` [PATCH 5/33] xfs: remove the xfs_extent_t typedef Andrey Albershteyn
2025-12-03 19:06 ` [PATCH 6/33] xfs: remove the xfs_extent32_t typedef Andrey Albershteyn
2025-12-03 19:07 ` [PATCH 7/33] xfs: remove the xfs_extent64_t typedef Andrey Albershteyn
2025-12-03 19:07 ` [PATCH 8/33] xfs: remove the xfs_efi_log_format_t typedef Andrey Albershteyn
2025-12-03 19:07 ` [PATCH 9/33] xfs: remove the xfs_efi_log_format_32_t typedef Andrey Albershteyn
2025-12-03 19:07 ` [PATCH 10/33] xfs: remove the xfs_efi_log_format_64_t typedef Andrey Albershteyn
2025-12-03 19:07 ` [PATCH 11/33] xfs: remove the xfs_efd_log_format_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 12/33] xfs: remove the unused xfs_efd_log_format_32_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 13/33] xfs: remove the unused xfs_efd_log_format_64_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 14/33] xfs: remove the unused xfs_buf_log_format_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 15/33] xfs: remove the unused xfs_dq_logformat_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 16/33] xfs: remove the unused xfs_qoff_logformat_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 17/33] xfs: remove the unused xfs_log_iovec_t typedef Andrey Albershteyn
2025-12-03 19:08 ` [PATCH 18/33] xfs: fix log CRC mismatches between i386 and other architectures Andrey Albershteyn
2025-12-03 19:09 ` [PATCH 19/33] xfs: move the XLOG_REG_ constants out of xfs_log_format.h Andrey Albershteyn
2025-12-03 19:09 ` [PATCH 20/33] xfs: remove the expr argument to XFS_TEST_ERROR Andrey Albershteyn
2025-12-03 19:09 ` [PATCH 21/33] xfs: improve default maximum number of open zones Andrey Albershteyn
2025-12-03 19:09 ` [PATCH 22/33] xfs: prevent gc from picking the same zone twice Andrey Albershteyn
2025-12-03 19:09 ` [PATCH 23/33] xfs: convert xfs_buf_log_format_t typedef to struct Andrey Albershteyn
2025-12-04 9:32 ` Christoph Hellwig
2025-12-04 10:00 ` Andrey Albershteyn
2025-12-04 10:08 ` Christoph Hellwig [this message]
2025-12-03 19:10 ` [PATCH 24/33] xfs: convert xlog_op_header_t " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 25/33] xfs: convert xfs_trans_header_t typdef " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 26/33] xfs: convert xfs_log_iovec_t typedef " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 27/33] xfs: convert xfs_qoff_logformat_t " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 28/33] xfs: convert xfs_dq_logformat_t " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 29/33] xfs: convert xfs_efi_log_format " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 30/33] xfs: convert xfs_efd_log_format_t " Andrey Albershteyn
2025-12-03 19:10 ` [PATCH 31/33] xfs: convert xfs_efi_log_format_32_t " Andrey Albershteyn
2025-12-03 19:11 ` [PATCH 32/33] xfs: convert xfs_extent_t " Andrey Albershteyn
2025-12-03 19:11 ` [PATCH 33/33] xfs: convert xfs_efi_log_format_64_t " Andrey Albershteyn
2025-12-04 9:28 ` [PATCH 0/34] xfsprogs: libxfs sync v6.18 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204100820.GA21013@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=aalbersh@redhat.com \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox