Re: [PATCH 2/4] repair: add canonical names for the XR_INO_ constants

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Dec 03, 2025 at 07:09:42AM +0100, Christoph Hellwig wrote:
> On Tue, Dec 02, 2025 at 09:59:19AM -0800, Darrick J. Wong wrote:
> > > Seems like the standard gettext thing to do is to mark the array
> > > initializers as N_(), which we do in quite a few places.  Not sure
> > > where the actual translation actually gets applied with that, though.
> > 
> > That N_() thing is #defined out of existence for compilation in
> > platform_defs.h:
> > 
> > # define N_(x)			 x
> > 
> > and include/buildrules passes "--keyword=N_" to xgettext so that it'll
> > find all the N_("string") strings and put them in the message catalog.
> > I think you still have to use regular _() (aka gettext()) when you pass
> > them to printf.
> > 
> > IOWs, you'd still have to define the strings array like this:
> > 
> > static const char *xr_ino_type_name[] = {
> > 	[XR_INO_UNKNOWN]	= N_("unknown"),
> > ...
> > };
> 
> Yes, that was the intent.
> 
> > to capture "unknown" in the .po file, but I think the printf argument
> > still has to call gettext() to look up the localized version.
> 
> And that's what I'd expect.  But there are no direct gettext calls
> anywhere in xfsprogs, despite quite a bit of N_() usage.  What am I
> missing?

#define _(x)		gettext(x)

in platform_defs.h.

(and no, I don't get anything meaningful out of "N_()" for magic
tagging and "_()" to mean lookup, but according to Debian codesearch
it's a common practice in things like binutils and git and vim)

--D