From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs/158: _notrun when the file system can't be created
Date: Fri, 5 Dec 2025 09:08:11 +0100 [thread overview]
Message-ID: <20251205080811.GA21212@lst.de> (raw)
In-Reply-To: <20251205073125.tddypzbg7lyrzwna@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Fri, Dec 05, 2025 at 03:31:25PM +0800, Zorro Lang wrote:
> > +_scratch_mkfs -m crc=1,inobtcount=0 || \
> > + _notrun "invalid feature combination" >> $seqres.full
>
> Hi Christoph,
>
> BTW, shouldn't we do ">> $seqres.full" behind the _scratch_mkfs, why does that
> for _notrun?
>
> Two patches of this patchset have been acked. As this patchset is a random fix,
> so I'd like to merge those 2 "acked" patches at first, then you can re-send
> the 3rd patch with other patches later. Is that good to you?
Please drop it. I have some ideas to attack the whole set of issues with
combining flags in a more systematic way, but I'll need some time to try
and test them.
next prev parent reply other threads:[~2025-12-05 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 7:10 misc xfstests fixes Christoph Hellwig
2025-11-21 7:10 ` [PATCH 1/3] generic/484: force I/O to the data device for XFS Christoph Hellwig
2025-11-21 16:35 ` Darrick J. Wong
2025-11-21 7:10 ` [PATCH 2/3] xfs/049: create the nested XFS file systems on the loop device Christoph Hellwig
2025-11-21 16:43 ` Darrick J. Wong
2025-11-21 7:10 ` [PATCH 3/3] xfs/158: _notrun when the file system can't be created Christoph Hellwig
2025-11-21 17:04 ` Darrick J. Wong
2025-12-02 4:49 ` Zorro Lang
2025-12-02 7:36 ` Christoph Hellwig
2025-12-02 8:40 ` Zorro Lang
2025-12-05 7:31 ` Zorro Lang
2025-12-05 8:08 ` Christoph Hellwig [this message]
2025-12-05 17:33 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205080811.GA21212@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox