Re: [PATCH 07/12] xfs/185: don't use SCRATCH_{,RT}DEV helpers

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Dec 10, 2025 at 06:46:53AM +0100, Christoph Hellwig wrote:
> This tests creates loop-based data and rt devices for testing.  Don't
> override SCRATCH_{,RT}DEV and don't use the helpers based on it because
> the options specified in MKFS_OPTIONS might not work for this
> configuration.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/185 | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/xfs/185 b/tests/xfs/185
> index 7aceb383ce46..84139be8e66e 100755
> --- a/tests/xfs/185
> +++ b/tests/xfs/185
<snip>
> @@ -64,16 +63,8 @@ rtminor=$(stat -c '%T' "$rtloop")
>  test $ddmajor -le $rtmajor || \
>  	_notrun "Data loopdev minor $ddminor larger than rt minor $rtminor"
>  
> -# Inject our custom-built devices as an rt-capable scratch device.
> -# We avoid touching "require_scratch" so that post-test fsck will not try to
> -# run on our synthesized scratch device.
> -old_use_external="$USE_EXTERNAL"
> -USE_EXTERNAL=yes
> -SCRATCH_RTDEV="$rtloop"
> -SCRATCH_DEV="$ddloop"
> -
> -_scratch_mkfs >> $seqres.full
> -_try_scratch_mount >> $seqres.full || \
> +$MKFS_XFS_PROG -r rtdev=$rtloop $ddloop  >> $seqres.full
> +mount -o rtdev=$rtloop $ddloop $SCRATCH_MNT >> $seqres.full || \
>  	_notrun "mount with injected rt device failed"

What happens if SCRATCH_LOGDEV is set?  I guess we ignore it, and
everything is good?  I suppose the logdev configuration isn't really
relevant here anyway.

If the answers are 'nothing' and 'yes' then
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  # Create a file that we'll use to seed fsmap entries for the rt device,
> -- 
> 2.47.3
> 
>