public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: validate that zoned RT devices are zone aligned
Date: Thu, 11 Dec 2025 06:04:17 +0100	[thread overview]
Message-ID: <20251211050417.GA26597@lst.de> (raw)
In-Reply-To: <20251210191825.GD7725@frogsfrogsfrogs>

On Wed, Dec 10, 2025 at 11:18:25AM -0800, Darrick J. Wong wrote:
> How nasty is it, exactly?  AFAICT,
> 
>  * The zone targetting code (aka the zone we copy into) then has to
>    know to avoid a runt endzone?

Yes.  And I don't really have a good idea how to do that.

>  * Thresholding gets weird because they don't apply right to the runt
>    zone, which means the victim selection is also off.

Yes.

>  * The code that reserves zones for gc or other ENOSPC handling then has
>    to ensure it never picks a runt zone to avoid corner case problems

This is what is needed for 1) above with all the same issues.

> Any other reasons?  Given that zoned is still experimental I think I'm
> ok with adding this restriction, but only after some more thorough
> understanding. :)

Yeah.

> Also does growfs need patching so that it doesn't create a runt zone?

I think we run the buffer verifier there, but a nicer check to abort
early would be helpful.  As would be a test case.


      reply	other threads:[~2025-12-11  5:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 14:23 [PATCH] xfs: validate that zoned RT devices are zone aligned Christoph Hellwig
2025-12-10 16:48 ` Darrick J. Wong
2025-12-10 16:54   ` Christoph Hellwig
2025-12-10 19:18     ` Darrick J. Wong
2025-12-11  5:04       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251211050417.GA26597@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox