From: "Darrick J. Wong" <djwong@kernel.org>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
bfoster@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfs: fix XFS_ERRTAG_FORCE_ZERO_RANGE for zoned file system
Date: Tue, 16 Dec 2025 07:54:31 -0800 [thread overview]
Message-ID: <20251216155431.GP7725@frogsfrogsfrogs> (raw)
In-Reply-To: <tbzmh2fl7vchasnqvosujidfttyftmkhmdt5odmzscdbj2x6qo@ln7n6m5aw7k3>
On Tue, Dec 16, 2025 at 09:11:13AM +0100, Carlos Maiolino wrote:
> On Tue, Dec 16, 2025 at 09:06:18AM +0100, Christoph Hellwig wrote:
> > On Tue, Dec 16, 2025 at 09:03:42AM +0100, Carlos Maiolino wrote:
> > > >
> > > > +/*
> > > > + * For various operations we need to zero up to one block each at each end of
> > >
> > > ^^^
> > > Is this correct? Or should have it been
> > > "one block at each end..." ?
> > >
> > > Not native English speaker so just double checking. I can update it when
> > > applying if it is not correct.
> >
> > Your version sounds correct.
> >
>
> o>
The original version is correct. If you have 4k fsblocks and a
zerorange request for 8GB - 2 bytes starting at 4097, you'll have to
actually zero 4097-8191 and 8589930496 - 8589934591. (Almost) one block
each, at each end.
That said, "one block at each end" conveys that adquately in modern day
English usage and people think I'm old fashioned even for uttering the
first version. ;)
(Old fashioned being 1960s :P)
--D
next prev parent reply other threads:[~2025-12-16 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <P_OCd7pNcLvRe038VeBLKmIi6KSgitIcPVyjn56Ucs9A34-ckTtKbjGP08W5TLKsAjB8PriOequE0_FNUOny-Q==@protonmail.internalid>
2025-12-15 6:05 ` [PATCH v2] xfs: fix XFS_ERRTAG_FORCE_ZERO_RANGE for zoned file system Christoph Hellwig
2025-12-16 8:03 ` Carlos Maiolino
2025-12-16 8:06 ` Christoph Hellwig
2025-12-16 8:11 ` Carlos Maiolino
2025-12-16 15:54 ` Darrick J. Wong [this message]
2025-12-16 17:31 ` Christoph Hellwig
2025-12-16 18:57 ` Brian Foster
2025-12-19 5:28 ` Christoph Hellwig
2025-12-19 14:01 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216155431.GP7725@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox