Re: [PATCH v2] xfs: fix XFS_ERRTAG_FORCE_ZERO_RANGE for zoned file system

[Christoph Hellwig <hch@lst.de>]

On Tue, Dec 16, 2025 at 01:57:43PM -0500, Brian Foster wrote:
> > +	if (xfs_is_zoned_inode(ip)) {
> > +		if (ac->reserved_blocks > XFS_ZONED_ZERO_EDGE_SPACE_RES) {
> > +			ASSERT(IS_ENABLED(CONFIG_XFS_DEBUG));
> 
> JFYI the reason I suggested a config check was as a safeguard against
> forced zeroing on production kernels. The assert here would compile out
> in that case, so won't necessarily provide that benefit (unless you
> wanted to use ASSERT_ALWAYS() or WARN() or something..).
> 
> A warning on WARN && !DEBUG is still useful so I don't really care if
> you leave it as is or tweak it. I just wanted to point that out.

I really think that anyone who modidifies this area should run a debug
kernel to test.  And if they the usual automated runs will catch it.
Having allocation beahvior modified based on CONFIG_XFS_DEBUG, and only
for a case that isn't supposed to happen seems weird and in would cause
weird heisenbugs if it ever hit.