public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-xfs@vger.kernel.org,
	Andrey Albershteyn <aalbersh@kernel.org>,
	Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Subject: Re: [PATCH v2 0/3] Enable cached zone report
Date: Fri, 19 Dec 2025 15:59:44 -0800	[thread overview]
Message-ID: <20251219235944.GH7725@frogsfrogsfrogs> (raw)
In-Reply-To: <20251219235602.GG7725@frogsfrogsfrogs>

On Fri, Dec 19, 2025 at 03:56:02PM -0800, Darrick J. Wong wrote:
> On Fri, Dec 19, 2025 at 06:38:07PM +0900, Damien Le Moal wrote:
> > Enable cached zone report to speed up mkfs and repair on a zoned block
> > device (e.g. an SMR disk). Cached zone report support was introduced in
> > the kernel with version 6.19-rc1.  This was co-developped with
> > Christoph.
> 
> Just out of curiosity, do you see any xfsprogs build problems with
> BLK_ZONE_COND_ACTIVE if the kernel headers are from 6.18?
> 
> > Darrick,
> > 
> > It may be cleaner to have a common report zones helper instead of
> > repating the same ioctl pattern in mkfs/xfs_mkfs.c and repair/zoned.c.
> > However, I am not sure where to place such helper. In libxfs/ or in
> > libfrog/ ? Please advise.
> 
> libfrog/, please.

and since I hit [send] without providing a reason, I'll request a
do-over:

libfrog/, please.  That's where we stuff all the support code, ioctl
wrappers, and data structures for xfsprogs nowadays.  It's better than
cluttering up libxfs/.

--D

> --D
> 
> > Thanks !
> > 
> > Changes from v1:
> >  - Fix erroneous handling of ioctl(BLKREPORTZONEV2) error to correctly
> >    fallback to the regular ioctl(BLKREPORTZONE) if the kernel does not
> >    support BLKREPORTZONEV2.
> > 
> > Damien Le Moal (3):
> >   libxfs: define BLKREPORTZONEV2 if the kernel does not provide it
> >   mkfs: use cached report zone
> >   repair: use cached report zone
> > 
> >  libxfs/topology.h | 8 ++++++++
> >  mkfs/xfs_mkfs.c   | 7 ++++++-
> >  repair/zoned.c    | 7 ++++++-
> >  3 files changed, 20 insertions(+), 2 deletions(-)
> > 
> > -- 
> > 2.52.0
> > 
> > 
> 

  reply	other threads:[~2025-12-19 23:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  9:38 [PATCH v2 0/3] Enable cached zone report Damien Le Moal
2025-12-19  9:38 ` [PATCH v2 1/3] libxfs: define BLKREPORTZONEV2 if the kernel does not provide it Damien Le Moal
2025-12-19  9:38 ` [PATCH v2 2/3] mkfs: use cached report zone Damien Le Moal
2025-12-19  9:38 ` [PATCH v2 3/3] repair: " Damien Le Moal
2025-12-19 23:56 ` [PATCH v2 0/3] Enable cached zone report Darrick J. Wong
2025-12-19 23:59   ` Darrick J. Wong [this message]
2025-12-20  0:00   ` Damien Le Moal
2025-12-20  1:54     ` Darrick J. Wong
2025-12-20  2:22       ` Damien Le Moal
2025-12-20  2:59       ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251219235944.GH7725@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=aalbersh@kernel.org \
    --cc=cem@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox