Re: [PATCH v3 2/6] mkfs: remove unnecessary return value affectation

["Darrick J. Wong" <djwong@kernel.org>]

On Sat, Dec 20, 2025 at 11:53:22AM +0900, Damien Le Moal wrote:
> The function report_zones() in mkfs/xfs_mkfs.c is a void function. So
> there is no need to set the variable ret to -EIO before returning if
> fstat() fails.
> 
> Fixes: 2e5a737a61d3 ("xfs_mkfs: support creating file system with zoned RT devices")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

LGTM,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  mkfs/xfs_mkfs.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index bc6a28b63c24..550fc011b614 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -2589,10 +2589,8 @@ report_zones(
>  		exit(1);
>  	}
>  
> -	if (fstat(fd, &st) < 0) {
> -		ret = -EIO;
> +	if (fstat(fd, &st) < 0)
>  		goto out_close;
> -	}
>  	if (!S_ISBLK(st.st_mode))
>  		goto out_close;
>  
> -- 
> 2.52.0
> 
>