Re: [PATCH] xfs_mdrestore: fix restoration on filesystems with 4k sectors

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jan 06, 2026 at 10:12:09PM -0800, Christoph Hellwig wrote:
> On Tue, Jan 06, 2026 at 10:48:27AM -0800, Darrick J. Wong wrote:
> > +	/*
> > +	 * The first block must be the primary super, which is at the start of
> > +	 * the data device, which is device 0.
> > +	 */
> > +	if (xme.xme_addr != 0)
> > +		fatal("Invalid superblock disk address 0x%llx\n",
> > +				be64_to_cpu(xme.xme_addr));
> >  
> >  	len = BBTOB(be32_to_cpu(xme.xme_len));
> >  
> > +	/* The primary superblock is always a single filesystem sector. */
> > +	if (len < BBTOB(1) || len > 1U << XFS_MAX_SECTORSIZE_LOG)
> 
> I'd use XFS_MAX_SECTORSIZE here instead of open coding the shift.
> 
> Otherwise looks good.

Fixed, thanks for reading! :)

--D