Re: [PATCH] xfs: improve the assert at the top of xfs_log_cover

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Jan 09, 2026 at 04:18:21PM +0100, Christoph Hellwig wrote:
> Move each condition into a separate assert so that we can see which
> on triggered.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Yes that's really helpful for observability;
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 511756429336..8ddd25970471 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1138,9 +1138,11 @@ xfs_log_cover(
>  	int			error = 0;
>  	bool			need_covered;
>  
> -	ASSERT((xlog_cil_empty(mp->m_log) && xlog_iclogs_empty(mp->m_log) &&
> -	        !xfs_ail_min_lsn(mp->m_log->l_ailp)) ||
> -		xlog_is_shutdown(mp->m_log));
> +	if (!xlog_is_shutdown(mp->m_log)) {
> +		ASSERT(xlog_cil_empty(mp->m_log));
> +		ASSERT(xlog_iclogs_empty(mp->m_log));
> +		ASSERT(!xfs_ail_min_lsn(mp->m_log->l_ailp));
> +	}
>  
>  	if (!xfs_log_writable(mp))
>  		return 0;
> -- 
> 2.47.3
> 
>