From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org, mark.tinguely@oracle.com
Subject: Re: [PATCH] xfs: remove xfs_attr_leaf_hasname
Date: Fri, 9 Jan 2026 09:41:27 -0800 [thread overview]
Message-ID: <20260109174127.GF15583@frogsfrogsfrogs> (raw)
In-Reply-To: <20260109163706.GA16131@lst.de>
On Fri, Jan 09, 2026 at 05:37:06PM +0100, Christoph Hellwig wrote:
> On Fri, Jan 09, 2026 at 08:29:11AM -0800, Darrick J. Wong wrote:
> > Blerrgh, xfs_attr3_leaf_lookup_int encoding results with error numbers
> > makes my brain hurt every time I look at the xattr code...
>
> Same. I've been really tempted to pass a separate bool multiple times.
> Maybe we should finally go for it? That would also remove most (but
> all of the issues) due to the block layer -ENODATA leak.
I support that.
--D
next prev parent reply other threads:[~2026-01-09 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:17 [PATCH] xfs: remove xfs_attr_leaf_hasname Christoph Hellwig
2026-01-09 16:29 ` Darrick J. Wong
2026-01-09 16:37 ` Christoph Hellwig
2026-01-09 17:41 ` Darrick J. Wong [this message]
2026-01-13 9:38 ` Carlos Maiolino
2026-01-13 13:26 ` Christoph Hellwig
2026-01-13 13:36 ` Niklas Cassel
2026-01-21 12:23 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109174127.GF15583@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=mark.tinguely@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox