Re: [PATCH 5/6] xfs: check that used blocks are smaller than the write pointer

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Jan 09, 2026 at 06:20:50PM +0100, Christoph Hellwig wrote:
> Any used block must have been written, this reject used blocks > write
> pointer.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Oops, we missed that :/
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_zone_alloc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
> index d8df219fd3b4..00260f70242f 100644
> --- a/fs/xfs/xfs_zone_alloc.c
> +++ b/fs/xfs/xfs_zone_alloc.c
> @@ -1033,6 +1033,13 @@ xfs_init_zone(
>  		return -EFSCORRUPTED;
>  	}
>  
> +	if (used > write_pointer) {
> +		xfs_warn(mp,
> +"zone %u has used counter (0x%x) larger than write pointer (0x%x).",
> +			 rtg_rgno(rtg), used, write_pointer);
> +		return -EFSCORRUPTED;
> +	}
> +
>  	if (write_pointer == 0 && used != 0) {
>  		xfs_warn(mp, "empty zone %u has non-zero used counter (0x%x).",
>  			rtg_rgno(rtg), used);
> -- 
> 2.47.3
> 
>