From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs: split and refactor zone validation
Date: Mon, 12 Jan 2026 11:12:38 +0100 [thread overview]
Message-ID: <20260112101238.GA7719@lst.de> (raw)
In-Reply-To: <20260110014413.GA15551@frogsfrogsfrogs>
On Fri, Jan 09, 2026 at 05:44:13PM -0800, Darrick J. Wong wrote:
> On Fri, Jan 09, 2026 at 06:20:49PM +0100, Christoph Hellwig wrote:
> > Currently xfs_zone_validate mixes validating the software zone state in
> > the XFS realtime group with validating the hardware state reported in
> > struct blk_zone and deriving the write pointer from that.
> >
> > Move all code that works on the realtime group to xfs_init_zone, and only
> > keep the hardware state validation in xfs_zone_validate. This makes the
> > code more clear, and allows for better reuse in userspace.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Hrmm. There's a lot going on in this patch. The code changes here are
> a lot of shuffling code around, and I think the end result is that there
> are (a) fewer small functions; (b) discovering the write pointer moves
> towards xfs_init_zone; and (c) here and elsewhere the validation of that
> write pointer shifts towards libxfs...?
Yeah. I initiall had this split up a bit more, but that made things
even harder to follow..
next prev parent reply other threads:[~2026-01-12 10:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 17:20 refactor zone reporting Christoph Hellwig
2026-01-09 17:20 ` [PATCH 1/6] xfs: add missing forward declaration in xfs_zones.h Christoph Hellwig
2026-01-10 0:50 ` Darrick J. Wong
2026-01-09 17:20 ` [PATCH 2/6] xfs: add a xfs_rtgroup_raw_size helper Christoph Hellwig
2026-01-10 1:00 ` Darrick J. Wong
2026-01-09 17:20 ` [PATCH 3/6] xfs: pass the write pointer to xfs_init_zone Christoph Hellwig
2026-01-10 1:11 ` Darrick J. Wong
2026-01-12 10:15 ` Damien Le Moal
2026-01-12 21:50 ` Darrick J. Wong
2026-01-13 7:47 ` Christoph Hellwig
2026-01-13 7:47 ` Christoph Hellwig
2026-01-13 9:27 ` Damien Le Moal
2026-01-09 17:20 ` [PATCH 4/6] xfs: split and refactor zone validation Christoph Hellwig
2026-01-10 1:44 ` Darrick J. Wong
2026-01-12 10:12 ` Christoph Hellwig [this message]
2026-01-09 17:20 ` [PATCH 5/6] xfs: check that used blocks are smaller than the write pointer Christoph Hellwig
2026-01-10 1:25 ` Darrick J. Wong
2026-01-09 17:20 ` [PATCH 6/6] xfs: use blkdev_get_zone_info to simply zone reporting Christoph Hellwig
2026-01-10 1:28 ` Darrick J. Wong
2026-01-13 10:33 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2026-01-14 6:53 refactor zone reporting v2 Christoph Hellwig
2026-01-14 6:53 ` [PATCH 4/6] xfs: split and refactor zone validation Christoph Hellwig
2026-01-14 10:04 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112101238.GA7719@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox