Re: [PATCH v2 11/22] xfs: add verity info pointer to xfs inode

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jan 12, 2026 at 03:51:10PM +0100, Andrey Albershteyn wrote:
> Add the fsverity_info pointer into the filesystem-specific part of the
> inode by adding the field xfs_inode->i_verity_info and configuring
> fsverity_operations::inode_info_offs accordingly.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

I kinda don't like adding another pointer to struct xfs_inode but I
can't see a better solution.  Inodes can add or drop verity status
dynamically so we can't do this trick:

struct xfs_verity_inode {
	struct xfs_inode	hork;
	struct fsverity_info	dork;
};

and only allocate the xfs_verity_inode when needed.  Therefore,

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_icache.c | 3 +++
>  fs/xfs/xfs_inode.h  | 5 +++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 23a920437f..872785c68a 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -130,6 +130,9 @@
>  	spin_lock_init(&ip->i_ioend_lock);
>  	ip->i_next_unlinked = NULLAGINO;
>  	ip->i_prev_unlinked = 0;
> +#ifdef CONFIG_FS_VERITY
> +	ip->i_verity_info = NULL;
> +#endif
>  
>  	return ip;
>  }
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index bd6d335571..f149cb1eb5 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -9,6 +9,7 @@
>  #include "xfs_inode_buf.h"
>  #include "xfs_inode_fork.h"
>  #include "xfs_inode_util.h"
> +#include <linux/fsverity.h>
>  
>  /*
>   * Kernel only inode definitions
> @@ -99,6 +100,10 @@
>  	spinlock_t		i_ioend_lock;
>  	struct work_struct	i_ioend_work;
>  	struct list_head	i_ioend_list;
> +
> +#ifdef CONFIG_FS_VERITY
> +	struct fsverity_info *i_verity_info;
> +#endif
>  } xfs_inode_t;
>  
>  static inline bool xfs_inode_on_unlinked_list(const struct xfs_inode *ip)
> 
> -- 
> - Andrey
> 
>