From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, mark.tinguely@oracle.com
Subject: Re: [PATCH] xfs: remove xfs_attr_leaf_hasname
Date: Tue, 13 Jan 2026 14:26:56 +0100 [thread overview]
Message-ID: <20260113132656.GA23871@lst.de> (raw)
In-Reply-To: <aWYSdZFviucuzeK0@nidhogg.toxiclabs.cc>
On Tue, Jan 13, 2026 at 10:38:25AM +0100, Carlos Maiolino wrote:
> On Fri, Jan 09, 2026 at 09:41:27AM -0800, Darrick J. Wong wrote:
> > On Fri, Jan 09, 2026 at 05:37:06PM +0100, Christoph Hellwig wrote:
> > > On Fri, Jan 09, 2026 at 08:29:11AM -0800, Darrick J. Wong wrote:
> > > > Blerrgh, xfs_attr3_leaf_lookup_int encoding results with error numbers
> > > > makes my brain hurt every time I look at the xattr code...
> > >
> > > Same. I've been really tempted to pass a separate bool multiple times.
> > > Maybe we should finally go for it? That would also remove most (but
> > > all of the issues) due to the block layer -ENODATA leak.
> >
> > I support that.
>
> +1.
>
> Should I pick this patch and you send and incremental one or should I
> just wait for a new one?
Please pick it up. Fixing up the attr/dir calling conventions will
be a big project that'll take a while and produce a lot of patches.
next prev parent reply other threads:[~2026-01-13 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:17 [PATCH] xfs: remove xfs_attr_leaf_hasname Christoph Hellwig
2026-01-09 16:29 ` Darrick J. Wong
2026-01-09 16:37 ` Christoph Hellwig
2026-01-09 17:41 ` Darrick J. Wong
2026-01-13 9:38 ` Carlos Maiolino
2026-01-13 13:26 ` Christoph Hellwig [this message]
2026-01-13 13:36 ` Niklas Cassel
2026-01-21 12:23 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113132656.GA23871@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mark.tinguely@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox