public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 11/11] xfs: add media verification ioctl
Date: Tue, 13 Jan 2026 22:19:30 -0800	[thread overview]
Message-ID: <20260114061930.GL15583@frogsfrogsfrogs> (raw)
In-Reply-To: <20260114061559.GA10613@lst.de>

On Wed, Jan 14, 2026 at 07:15:59AM +0100, Christoph Hellwig wrote:
> On Tue, Jan 13, 2026 at 10:07:05PM -0800, Darrick J. Wong wrote:
> > > a tunable is a better choice here at least for now.
> > 
> > <nod> I'll set iosize to 1MB by default and userspace can decrease it if
> > it so desires.
> > 
> > Also it occurs to me that max_hw_sectors_kb seems to be 128K for all of
> > my consumer nvme devices, and the fancy Intel ones too.  Funny that the
> > sata ssds set it to 4MB, but I guess capping at 128k is one way to
> > reduce the command latency...?  (Or the kernel's broken?  I can't figure
> > out how to get mpsmin with nvme-cli...)
> 
> mpsmin is basically always 4k.
> 
> 
> On something unrelated:  SSDs remap all the time by definition, and
> HDDs are really good at remapping bad sectors these days as well.
> So verifying blocks that do not actually contain file system (meta)data
> is pretty pointless.   Can we come up with a way to verify only blocks
> that have valid data in them, while still being resonably sequential?
> I.e. walk the rmap?

xfs_scrub phase6 already calls getfsmap to figure out which parts of the
disk actually contain written data of any kind and are worth verifying.

--D

  reply	other threads:[~2026-01-14  6:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  0:32 [PATCHSET v5] xfs: autonomous self healing of filesystems Darrick J. Wong
2026-01-13  0:32 ` [PATCH 01/11] docs: discuss autonomous self healing in the xfs online repair design doc Darrick J. Wong
2026-01-13 16:00   ` Christoph Hellwig
2026-01-13  0:33 ` [PATCH 02/11] xfs: start creating infrastructure for health monitoring Darrick J. Wong
2026-01-13 16:03   ` Christoph Hellwig
2026-01-13  0:33 ` [PATCH 03/11] xfs: create event queuing, formatting, and discovery infrastructure Darrick J. Wong
2026-01-13 16:05   ` Christoph Hellwig
2026-01-13  0:33 ` [PATCH 04/11] xfs: convey filesystem unmount events to the health monitor Darrick J. Wong
2026-01-13 16:11   ` Christoph Hellwig
2026-01-13 18:48     ` Darrick J. Wong
2026-01-13  0:33 ` [PATCH 05/11] xfs: convey metadata health " Darrick J. Wong
2026-01-13 16:11   ` Christoph Hellwig
2026-01-13  0:34 ` [PATCH 06/11] xfs: convey filesystem shutdown " Darrick J. Wong
2026-01-13 16:14   ` Christoph Hellwig
2026-01-13 19:01     ` Darrick J. Wong
2026-01-13  0:34 ` [PATCH 07/11] xfs: convey externally discovered fsdax media errors " Darrick J. Wong
2026-01-13 16:15   ` Christoph Hellwig
2026-01-13  0:34 ` [PATCH 08/11] xfs: convey file I/O " Darrick J. Wong
2026-01-13 16:15   ` Christoph Hellwig
2026-01-13  0:34 ` [PATCH 09/11] xfs: allow reconfiguration of the health monitoring device Darrick J. Wong
2026-01-13 16:17   ` Christoph Hellwig
2026-01-13 18:28     ` Darrick J. Wong
2026-01-13  0:35 ` [PATCH 10/11] xfs: check if an open file is on the health monitored fs Darrick J. Wong
2026-01-13 16:17   ` Christoph Hellwig
2026-01-13  0:35 ` [PATCH 11/11] xfs: add media verification ioctl Darrick J. Wong
2026-01-13 15:57   ` Christoph Hellwig
2026-01-13 23:21     ` Darrick J. Wong
2026-01-14  5:40       ` Darrick J. Wong
2026-01-14  6:02       ` Christoph Hellwig
2026-01-14  6:07         ` Darrick J. Wong
2026-01-14  6:15           ` Christoph Hellwig
2026-01-14  6:19             ` Darrick J. Wong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-01-16  5:42 [PATCHSET v6] xfs: autonomous self healing of filesystems Darrick J. Wong
2026-01-16  5:44 ` [PATCH 11/11] xfs: add media verification ioctl Darrick J. Wong
2026-01-19 15:56   ` Christoph Hellwig
2026-01-19 17:35     ` Darrick J. Wong
2026-01-21  6:34 [PATCHSET v7 1/3] xfs: autonomous self healing of filesystems Darrick J. Wong
2026-01-21  6:37 ` [PATCH 11/11] xfs: add media verification ioctl Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114061930.GL15583@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=cem@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox