Re: [RFC PATCH 2/2] fsr: Always print error messages from xfrog_defragrange()

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jan 19, 2026 at 03:26:51PM +0100, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Error messages when xfrog_defragrange() are only printed when
> verbose/debug flages are used.
> 
> We had reports from users complaining it's hard to find out error
> messages in the middle of dozens of other informational messages.
> 
> Particularly I think error messages are better to be printed
> independently of verbose/debug flags, so unconditionally print those.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

That seems like a reasonable behavior to me.  On some level these
errors probably ought to be printed to stderr instead of stdout, but
nothing else in packfile() seems to do that so maybe we just leave that
alone?

Anyway silently dropping "did not actually defrag the file" errors by
default seems counterintuitive so

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fsr/xfs_fsr.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index 8845ff172fcb..fadb53af062d 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -1464,19 +1464,15 @@ packfile(
>  		case 0:
>  			break;
>  	case ENOTSUP:
> -		if (vflag || dflag)
> -			fsrprintf(_("%s: file type not supported\n"), fname);
> +		fsrprintf(_("%s: file type not supported\n"), fname);
>  		break;
>  	case EFAULT:
>  		/* The file has changed since we started the copy */
> -		if (vflag || dflag)
> -			fsrprintf(_("%s: file modified defrag aborted\n"),
> -					fname);
> +		fsrprintf(_("%s: file modified defrag aborted\n"), fname);
>  		break;
>  	case EBUSY:
>  		/* Timestamp has changed or mmap'ed file */
> -		if (vflag || dflag)
> -			fsrprintf(_("%s: file busy\n"), fname);
> +		fsrprintf(_("%s: file busy\n"), fname);
>  		break;
>  	default:
>  		fsrprintf(_("XFS_IOC_SWAPEXT failed: %s: %s\n"),
> -- 
> 2.52.0
> 
>