From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF7DF425CEC for ; Tue, 20 Jan 2026 17:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768929836; cv=none; b=BCA6T6KUE5QfvYd3DWnQvPloVpyYN1WO19BgiGjUSqdYgyoJQIfK8VuizLVMQ1AyQKPtD3RlgL2iHCMiF8MG/1p5PEfP2lN3L9dE0lkXBVQLwNaRp+kzrGi566ldVgD1yJqUXXEf+Jj4Kd6gAZeAdFibEsyMGJgEIUfY/icU5fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768929836; c=relaxed/simple; bh=r9B+o1VVJC/f9cfpYSHIQ2jtwhg722KVe/34I15Wa+U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cpHEOGsILFvh7AU3JwLxG/+zph7VdwU3Oux6D4Dtr9Myqzh5DHJHnuK6FrYbExV1igZHuqgXFIXjlkrWTRMTRSsVUq6DFmQx6gYmZXkfjd7I15PAhLQwUpfNtfaLSK4PYnV3EJCwEUrtkKq6eQ+cabSRk7+imx6N7gjXc3oEdiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=napCvG9p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="napCvG9p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48FEFC16AAE; Tue, 20 Jan 2026 17:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768929836; bh=r9B+o1VVJC/f9cfpYSHIQ2jtwhg722KVe/34I15Wa+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=napCvG9p3cWUO+EYd4zjLXeyYtWDrVb1lD4Xo0qDIdY/uMTbmDhJaC9BjZTxCou9T 77hEm4UyKFRAUKueHvjSOt23q/oxVWpx6/OZOJPoufdZijljVBhwmUUahjIPTwMXjQ SrFWsp2jgDiMaoHROPhQisgqg7tvovddYNFXEVkF2b/q9KvXLL5YFVHY8UH/iBMHPO XdhNXMC0nbNNs2QH7orGgH+IagMrWiWDG8R5g4NvnTOQvUmfX3rYwPfQvWpL24Y606 WEidNGt75WTbVXQ24TdUCnzaO8Iu9nR6IBUhQLqN7cNeequvPGZYtg6hQ4sokhfmq0 WFWzqE3NohhFw== Date: Tue, 20 Jan 2026 09:23:55 -0800 From: "Darrick J. Wong" To: cem@kernel.org Cc: aalbersh@redhat.com, linux-xfs@vger.kernel.org Subject: Re: [RFC PATCH 2/2] fsr: Always print error messages from xfrog_defragrange() Message-ID: <20260120172355.GP15551@frogsfrogsfrogs> References: <20260119142724.284933-1-cem@kernel.org> <20260119142724.284933-3-cem@kernel.org> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260119142724.284933-3-cem@kernel.org> On Mon, Jan 19, 2026 at 03:26:51PM +0100, cem@kernel.org wrote: > From: Carlos Maiolino > > Error messages when xfrog_defragrange() are only printed when > verbose/debug flages are used. > > We had reports from users complaining it's hard to find out error > messages in the middle of dozens of other informational messages. > > Particularly I think error messages are better to be printed > independently of verbose/debug flags, so unconditionally print those. > > Signed-off-by: Carlos Maiolino That seems like a reasonable behavior to me. On some level these errors probably ought to be printed to stderr instead of stdout, but nothing else in packfile() seems to do that so maybe we just leave that alone? Anyway silently dropping "did not actually defrag the file" errors by default seems counterintuitive so Reviewed-by: "Darrick J. Wong" --D > --- > fsr/xfs_fsr.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c > index 8845ff172fcb..fadb53af062d 100644 > --- a/fsr/xfs_fsr.c > +++ b/fsr/xfs_fsr.c > @@ -1464,19 +1464,15 @@ packfile( > case 0: > break; > case ENOTSUP: > - if (vflag || dflag) > - fsrprintf(_("%s: file type not supported\n"), fname); > + fsrprintf(_("%s: file type not supported\n"), fname); > break; > case EFAULT: > /* The file has changed since we started the copy */ > - if (vflag || dflag) > - fsrprintf(_("%s: file modified defrag aborted\n"), > - fname); > + fsrprintf(_("%s: file modified defrag aborted\n"), fname); > break; > case EBUSY: > /* Timestamp has changed or mmap'ed file */ > - if (vflag || dflag) > - fsrprintf(_("%s: file busy\n"), fname); > + fsrprintf(_("%s: file busy\n"), fname); > break; > default: > fsrprintf(_("XFS_IOC_SWAPEXT failed: %s: %s\n"), > -- > 2.52.0 > >