Re: [PATCH 1/4] xfs: use blkdev_report_zones_cached()

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jan 20, 2026 at 03:28:29PM +0100, Andrey Albershteyn wrote:
> On 2026-01-09 17:22:52, Christoph Hellwig wrote:
> > From: Damien Le Moal <dlemoal@kernel.org>
> > 
> > Source kernel commit: e04ccfc28252f181ea8d469d834b48e7dece65b2
> > 
> > Modify xfs_mount_zones() to replace the call to blkdev_report_zones()
> > with blkdev_report_zones_cached() to speed-up mount operations.
> > Since this causes xfs_zone_validate_seq() to see zones with the
> > BLK_ZONE_COND_ACTIVE condition, this function is also modified to acept
> > this condition as valid.
> > 
> > With this change, mounting a freshly formatted large capacity (30 TB)
> > SMR HDD completes under 2s compared to over 4.7s before.
> > 
> > Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> >  include/platform_defs.h | 4 ++++
> >  libxfs/xfs_zones.c      | 1 +
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/include/platform_defs.h b/include/platform_defs.h
> > index da966490b0f5..cfdaca642645 100644
> > --- a/include/platform_defs.h
> > +++ b/include/platform_defs.h
> > @@ -307,4 +307,8 @@ struct kvec {
> >  	size_t iov_len;
> >  };
> >  
> > +#ifndef BLK_ZONE_COND_ACTIVE /* added in Linux 6.19 */
> > +#define BLK_ZONE_COND_ACTIVE	0xff
> 
> hmm I think #ifndef doesn't work for enum member. Compiling against
> linux 6.19-rc6: 
> 
> ../include/platform_defs.h:311:33: error: expected identifier before numeric constant
>   311 | #define BLK_ZONE_COND_ACTIVE    0xff
>       |                                 ^~~~
> /linux-headers-v6.19-rc6/include/linux/blkzoned.h:84:9: note: in expansion of macro ‘BLK_ZONE_COND_ACTIVE’
>    84 |         BLK_ZONE_COND_ACTIVE    = 0xFF,
>       |         ^~~~~~~~~~~~~~~~~~~~

I hacked around this very crudely:
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git/commit/?h=djwong-wtf&id=d5d9b4bd2da95c7b9429112f1c1098a62f155270

Though I think one of hch's fix patches fixed that.  I cannot post a
lore link because the #@!%)*&!%!!! anubis b@%#%!!! is completely broken
and will not let me in.  But we did the review for the kernel-side fixes
within the last couple of weeks.

--D

> 
> -- 
> - Andrey
> 
>