Re: [PATCH 1/4] xfs: use blkdev_report_zones_cached()

[Christoph Hellwig <hch@lst.de>]

On Tue, Jan 20, 2026 at 09:31:19AM -0800, Darrick J. Wong wrote:
> > > +#ifndef BLK_ZONE_COND_ACTIVE /* added in Linux 6.19 */
> > > +#define BLK_ZONE_COND_ACTIVE	0xff
> > 
> > hmm I think #ifndef doesn't work for enum member. Compiling against
> > linux 6.19-rc6: 
> > 
> > ../include/platform_defs.h:311:33: error: expected identifier before numeric constant
> >   311 | #define BLK_ZONE_COND_ACTIVE    0xff
> >       |                                 ^~~~
> > /linux-headers-v6.19-rc6/include/linux/blkzoned.h:84:9: note: in expansion of macro ‘BLK_ZONE_COND_ACTIVE’
> >    84 |         BLK_ZONE_COND_ACTIVE    = 0xFF,
> >       |         ^~~~~~~~~~~~~~~~~~~~
> 
> I hacked around this very crudely:
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git/commit/?h=djwong-wtf&id=d5d9b4bd2da95c7b9429112f1c1098a62f155270

Urgg.  That's why we should not use enums in uapi headers..

Damien, I guess we could do a:

#define BLK_ZONE_COND_ACTIVE	BLK_ZONE_COND_ACTIVE

as the usual trick to fix that in the blkzoned.h header, and given
that 6.19 hasn't been released still get it to Linus in time.

> Though I think one of hch's fix patches fixed that.  I cannot post a
> lore link because the #@!%)*&!%!!! anubis b@%#%!!! is completely broken
> and will not let me in.  But we did the review for the kernel-side fixes
> within the last couple of weeks.

I don't think I fixed it.  Not intentionally, and not unintentionally
in a way I'd actually understand at least :)