From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org,
syzbot+0391d34e801643e2809b@syzkaller.appspotmail.com
Subject: Re: [PATCH 3/3] xfs: switch (back) to a per-buftarg buffer hash
Date: Thu, 22 Jan 2026 23:01:39 -0800 [thread overview]
Message-ID: <20260123070139.GP5945@frogsfrogsfrogs> (raw)
In-Reply-To: <20260123053619.GB24680@lst.de>
On Fri, Jan 23, 2026 at 06:36:19AM +0100, Christoph Hellwig wrote:
> On Thu, Jan 22, 2026 at 10:10:12AM -0800, Darrick J. Wong wrote:
> > Anyone want to venture forth with a fixes tag?
> >
> > (Though I wonder if a less invasive fix for LTS kernels would be to make
> > unmount wait for xg_ref to hit zero, though I guess that runs the risk
> > of stuck mounts if someone leaks a xfs_group reference)
>
> I tried. It probably is the patch that initially added the per-ag
> rbtrees:
>
> 74f75a0cb7033918eb0fa4a50df25091ac75c16e
> Author: Dave Chinner <dchinner@redhat.com>
> Date: Fri Sep 24 19:59:04 2010 +1000
>
> xfs: convert buffer cache hash to rbtree
>
> but as I can't reproduce the issue locally, and getting syzbot to
> verify it required horribly hacker to avoid lockdep I can't actually
> confirm it.
Yeah, I, uh, rely on syzbot reporters to test the patches because I
can't make head nor tails of the horrid reproducer code it generates.
Granted, the reproducer code is a lot less awful than it was back in
2017.
--D
next prev parent reply other threads:[~2026-01-23 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 5:26 buffer cache simplification v2 Christoph Hellwig
2026-01-22 5:26 ` [PATCH 1/3] xfs: don't keep a reference for buffers on the LRU Christoph Hellwig
2026-01-23 11:55 ` Carlos Maiolino
2026-01-23 16:01 ` Brian Foster
2026-01-22 5:26 ` [PATCH 2/3] xfs: use a lockref for the buffer reference count Christoph Hellwig
2026-01-23 12:04 ` Carlos Maiolino
2026-01-22 5:26 ` [PATCH 3/3] xfs: switch (back) to a per-buftarg buffer hash Christoph Hellwig
2026-01-22 18:10 ` Darrick J. Wong
2026-01-23 5:36 ` Christoph Hellwig
2026-01-23 7:01 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-26 5:37 buffer cache simplification v3 Christoph Hellwig
2026-01-26 5:38 ` [PATCH 3/3] xfs: switch (back) to a per-buftarg buffer hash Christoph Hellwig
2026-01-19 15:31 buffer cache simplification Christoph Hellwig
2026-01-19 15:31 ` [PATCH 3/3] xfs: switch (back) to a per-buftarg buffer hash Christoph Hellwig
2026-01-20 2:39 ` Darrick J. Wong
2026-01-20 7:06 ` Christoph Hellwig
2026-01-20 15:50 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123070139.GP5945@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+0391d34e801643e2809b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox